Use filter for logical OR in Makefile #3977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidgaspardev, thanks a lot for the PR. Do you mind amending the commit message like so? |
|
BTW, I rebased your branch over master for you, make sure to pull first. |
|
@dfunckt, I apologize for the confusion, but it appears that there is still an issue with the workflow. Could you please elaborate on your previous instructions, or perhaps provide some additional guidance to help resolve this problem? Thanks! |
|
You need in one of your commit ending with a line with Another (maybe easier) solution is to prefix the title of one of your commit with |
Can use filter function to simulate a logical OR with ifneq. Change-type: patch
|
Superseded by #4132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can use filter function to simulate a logical OR with ifneq.
See here: https://lists.gnu.org/archive/html/make-w32/2004-03/msg00062.html