use latest build asset(s) #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change-type: patch
Page-
reviewed
Aug 9, 2023
| ARG GH_RUN_ID=5794478637 | ||
|
|
||
| RUN --mount=type=secret,id=GITHUB_TOKEN \ | ||
| GH_TOKEN=$(cat < /run/secrets/GITHUB_TOKEN) gh run download -R distribution/distribution "${GH_RUN_ID}" -n registry \ |
There was a problem hiding this comment.
I assume this downloads the artifact from the run? They expire after a certain period so this will definitely bite us fairly soon
There was a problem hiding this comment.
yes, almost certainly every time this builds, GH_RUN_ID would need to be incremented (assuming there is something there to increment to).
There was a problem hiding this comment.
One thing we can do, aside from forking and potentially having to set up our own build pipelines, is to store/cache the build blob in git here @Page-
auto-merge was automatically disabled
November 12, 2023 22:23
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Docker are having issues releasing their software, this is a workaround to use a more recent CI release/build.
Passed in staging using IPv6-only AWS instance.