Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openBalena 2024 #141

Merged
merged 1 commit into from
May 28, 2024
Merged

openBalena 2024 #141

merged 1 commit into from
May 28, 2024

Conversation

@ab77 ab77 added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Feb 24, 2022
@ab77 ab77 force-pushed the ab77/open-balena branch 5 times, most recently from a7fd587 to 2622eb9 Compare March 1, 2022 18:50
@ab77 ab77 changed the title openBalena on balenaOS (WIP) openBalena on balenaOS Mar 8, 2022
@ab77 ab77 force-pushed the ab77/open-balena branch 20 times, most recently from 1c24cdf to 8394b73 Compare March 10, 2022 16:57
@ab77 ab77 enabled auto-merge May 23, 2024 16:44
@ab77 ab77 requested a review from klutchell May 23, 2024 16:44
@klutchell
Copy link
Contributor

I've never seen policy-bot invalidate on push like that. I always thought it was a setting that was only enforced for one approval rule but other approval rules could still pass.

I wonder if it's related to our permissions on this repo?

@klutchell
Copy link
Contributor

LGTM

@klutchell
Copy link
Contributor

I've never seen policy-bot invalidate on push like that. I always thought it was a setting that was only enforced for one approval rule but other approval rules could still pass.

I wonder if it's related to our permissions on this repo?

Oh, it's because I'm an author. I cannot approve.

@ab77
Copy link
Contributor Author

ab77 commented May 23, 2024

Oh, it's because I'm an author. I cannot approve.

We both are now :)

@ab77 ab77 force-pushed the ab77/open-balena branch 4 times, most recently from 08a8390 to e685f8a Compare May 23, 2024 23:53
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ The parts that I can understand look fine 👍

@ab77 ab77 force-pushed the ab77/open-balena branch 4 times, most recently from 8fb9739 to 7229840 Compare May 28, 2024 21:19
@ab77 ab77 requested review from thgreasi and dfunckt May 28, 2024 21:29
* integration/e2e tests
* automatic SSL/TLS PKI (wildcard cert.) generation via DNS-01 challenge
* update getting started guide
* remove unnecessary privileges (Redis)
* pin Redis to v7.2 (BSD license)
* enable trust proxy

Co-authored-by: Kyle Harding <[email protected]>

change-type: major
@ab77
Copy link
Contributor Author

ab77 commented May 28, 2024

@thgreasi or @dfunckt when you have a moment, I think we are done here. Please add your final approvals on this rebase/squash and let's get this merged. Then we can resolve/close the open community PRs, if their owners still care and their reality matches ours, and hopefully have this project automatically maintained by Renovate and Co.

@ab77 ab77 merged commit fe764b0 into master May 28, 2024
46 checks passed
@ab77 ab77 deleted the ab77/open-balena branch May 28, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants