Pin iptables to 1.8.9 (legacy) #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipex
reviewed
Mar 18, 2024
With Alpine 3.19, iptables gets bumped to 1.8.10 which uses nftables. The host OS still uses iptables 1.8.7 (legacy), and we should use legacy as well until the OS uses nftables. See: https://balena.zulipchat.com/#narrow/stream/345889-balena-io.2Fos/topic/iptables.20host.20vs.2E.20nftables.20Supervisor Change-type: patch Signed-off-by: Christina Ying Wang <[email protected]>
cywang117
force-pushed
the
pin-iptables-to-legacy
branch
from
4daf15f
to
3d88134
Compare
pipex
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Alpine 3.19, iptables gets bumped to 1.8.10 which uses nftables. The host OS still uses iptables 1.8.7 (legacy), and the compatibility of legacy & nftables is questionable. At the minimum, nftables-created rules don't appear when running iptables -L using legacy iptables, and this is confusing for users. Worst case scenario, rules made with iptables-nftables don't apply at all, leaving the device vulnerable.
See: https://balena.zulipchat.com/#narrow/stream/345889-balena-io.2Fos/topic/iptables.20host.20vs.2E.20nftables.20Supervisor
Change-type: patch
Tested by running on a device using
npm run syncand verifying iptables version usingiptables -V. Also checked rules were still applied and iptables otherwise functions properly usingiptables -L, both from host and in Supervisor container.