Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overwriting field name in ToJson method #35

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Sep 11, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#7004

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@lnash94 lnash94 marked this pull request as ready for review September 13, 2024 06:02
@lnash94 lnash94 changed the title [WIP] Add support for overwriting field name in ToJson method Add support for overwriting field name in ToJson method Sep 13, 2024
ballerina/json_api.bal Outdated Show resolved Hide resolved
hasithaa
hasithaa previously approved these changes Sep 13, 2024
Copy link
Contributor

@hasithaa hasithaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me. @SasinduDilshara Can you verify it?

ballerina/json_api.bal Outdated Show resolved Hide resolved
ballerina/json_api.bal Outdated Show resolved Hide resolved
ballerina/json_api.bal Outdated Show resolved Hide resolved
ballerina/json_api.bal Outdated Show resolved Hide resolved
ballerina/json_api.bal Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the toJson function to overwrite json property with the given name
5 participants