Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle recursive types in the data.jsondata compiler plugin #41

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Handle recursive types in the data.jsondata compiler plugin #41

merged 4 commits into from
Sep 23, 2024

Conversation

SasinduDilshara
Copy link
Contributor

TharmiganK
TharmiganK reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If possible, shall we add tests as well?

@SasinduDilshara
Copy link
Contributor Author

LGTM If possible, shall we add tests as well?

There are testcases for scenarios.
There is a need to add tests for union type symbols.
Will add that as a separate task

@SasinduDilshara
Copy link
Contributor Author

LGTM If possible, shall we add tests as well?

There are testcases for scenarios. There is a need to add tests for union type symbols. Will add that as a separate task

Will track in ballerina-platform/ballerina-library#7015

@SasinduDilshara SasinduDilshara merged commit b55778b into ballerina-platform:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TharmiganK TharmiganK TharmiganK left review comments

@lnash94 lnash94 lnash94 approved these changes

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@SasinduDilshara @lnash94 @TharmiganK