Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Adding All Possible Federated Directives to SDL String #1555

Merged

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Jul 26, 2023

Purpose

Fixes: ballerina-platform/ballerina-library#4681

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools)

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (0066718) 86.67% compared to head (2e5d514) 86.60%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1555      +/-   ##
============================================
- Coverage     86.67%   86.60%   -0.08%     
  Complexity      578      578              
============================================
  Files           115      115              
  Lines          8300     8286      -14     
  Branches       3379     3379              
============================================
- Hits           7194     7176      -18     
- Misses          869      872       +3     
- Partials        237      238       +1     
Files Changed Coverage Δ
...dlib/graphql/commons/types/FederatedDirective.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

changelog.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ThisaruGuruge ThisaruGuruge merged commit 287c76a into ballerina-platform:master Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid Adding All Possible Federated Directives to SDL String in GraphQL Subgraph
3 participants