Support Android Application Bundles #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbymelvin
commented
Oct 1, 2020
| @@ -13,7 +13,8 @@ class CordovaAction < Action | |||
| keystore_alias: 'alias', | |||
| build_number: 'versionCode', | |||
| min_sdk_version: 'gradleArg=-PcdvMinSdkVersion', | |||
| cordova_no_fetch: 'cordovaNoFetch' | |||
| cordova_no_fetch: 'cordovaNoFetch', | |||
| package_type: 'packageType' | |||
There was a problem hiding this comment.
type makes more sense here, IMO. However, I figured it'd be easily conflated with the type param used for iOS (CORDOVA_IOS_PACKAGE_TYPE).
Comment on lines
+125
to
+126
| android_package_type = params[:package_type] || 'apk' | ||
| android_package_extension = android_package_type == 'bundle' ? '.aab' : '.apk' |
There was a problem hiding this comment.
Default to building apk files, unless package_type specifies otherwise.
|
@Almouro Any thoughts on this? I'd love to hear what you think. |
Almouro
approved these changes
Oct 28, 2020
|
Makes a lot of sense, thanks @colbymelvin for nicely taking care of this! |
|
@colbymelvin included in version 3.1.0 :) |
mlegenhausen
pushed a commit
to werk85/fastlane-plugin-cordova
that referenced
this pull request
Nov 4, 2020
mlegenhausen
pushed a commit
to werk85/fastlane-plugin-cordova
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this plugin, it's great! This PR addresses #47 by enabling the building of Android Application Bundles (.aab files) in a backwards-compatible manner.
Please LMK if I missed anything, or if you'd like any additional changes!