Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the type and value of each variable passed to function get_start_block #303

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

barakman
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Lesigh-3100 Lesigh-3100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't something we want in general info-level logs. Can you please change it to debug?

@barakman
Copy link
Collaborator Author

This isn't something we want in general info-level logs. Can you please change it to debug?

If it gets masked out by some logging-level threshold or whatever, then it will miss out on the whole point in this PR to begin with, and we are left with the same logging output by the time the problem happens again.

@barakman barakman closed this Jan 16, 2024
@barakman barakman reopened this Jan 16, 2024
@mikewcasale mikewcasale dismissed Lesigh-3100’s stale review January 16, 2024 17:27

We decided this approach is OK.

@mikewcasale mikewcasale merged commit 7ab38c9 into main Jan 16, 2024
3 checks passed
@mikewcasale mikewcasale deleted the log-get_start_block-input branch January 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants