-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solidly curves #322
Merged
Merged
Solidly curves #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklbancor
force-pushed
the
solidly
branch
8 times, most recently
from
January 23, 2024 21:15
b6c0f1c
to
7d60f8c
Compare
sklbancor
force-pushed
the
solidly
branch
12 times, most recently
from
March 21, 2024 10:12
52f9c25
to
7b6c2a7
Compare
barakman
requested changes
Mar 21, 2024
Update README.md
Update functions.py Update functions.py Update functions.py
from_xpxp Update funcsAMM.py Update core.py Update core.py
barakman
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of the Solidly curve implementation (part one is here). It adds a few further analytics, but more importantly, it now adds the ability to add Solidity curves to the optimizer.
This is implemented via the new CPC method
from_solidly
that should be called with the two token balancesx
andy
(obviously consistent with thepair
provided, in tokens as floats).VERY IMPORTANTLY, THE METHOD RETURNS A LIST OF CURVERS, RATHER THAN A SINGLE CURVE. The calling code should be able to handle the following situations
Integration instructions
The code in this PR is now ready for integration:
*as discussed previously, currently we only have one curve; when we have multiple curves you can be sure that the signs of the dx will all be the same (or zero), and ditto for the dy; most likely all but one will be maxed out, but you should not rely on it (and I don't think you care anyway)