331 trading on aerodrome v2 is not properly supported #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakman
requested changes
Jan 25, 2024
barakman
requested changes
Jan 25, 2024
barakman
requested changes
Jan 25, 2024
barakman
requested changes
Jan 25, 2024
mikewcasale
approved these changes
Jan 29, 2024
barakman
approved these changes
Jan 29, 2024
mikewcasale
deleted the
331-trading-on-aerodrome_v2-is-not-properly-supported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue:
#331
The bug occurred in async_event_update_utils.py specifically for Solidly-fork exchanges.
The issue was that Solidly forks require the Factory contract to get the pool's fee, and when get_fee was called in the function get_token_and_fee, the exchange object had not been properly initialized with its factory contract. I changed the function to use the exchange object that was already initialized on startup, stored in Manager base.py.