Add L1 gas fee calculation on Optimism & forks #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forks-should-account-for-l1-gas-fee
barakman
requested changes
Jan 30, 2024
barakman
reviewed
Jan 31, 2024
barakman
reviewed
Jan 31, 2024
barakman
reviewed
Jan 31, 2024
barakman
reviewed
Jan 31, 2024
barakman
approved these changes
Jan 31, 2024
mikewcasale
deleted the
336-transactions-on-base-and-other-optimism-forks-should-account-for-l1-gas-fee
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds the calculation for "L1 Gas Fee" for transactions on Optimism & Optimism forks such as Base.
This gas fee is calculated & added to the current fee calculations to generate a much more accurate value for the expected transaction cost.
Note:
Signing transactions has been moved outside the submit_transaction and submit_transaction_private functions to prevent signing the transaction twice as part of this flow.