Fix handling of Solidly Factory ABI for equalizer & scale #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakman
requested changes
Feb 14, 2024
There was a problem hiding this comment.
In each one of the following functions:
get_abiget_factory_abiget_fee
Split the handling of self.exchange_name into the following 6 cases:
- if
"velocimeter_v2"... - elif
"scale_v2"... - elif
"equalizer_v2"... - elif
"solidly_v2"... - elif
"aerodrome_v2"... - else: raise an exception
And handle each case completely separately even if it happens to be identical to one of the other cases.
Please use == only (no "if in list" or similar).
barakman
requested changes
Feb 14, 2024
barakman
requested changes
Feb 14, 2024
barakman
requested changes
Feb 15, 2024
…y-factory-abi-used-for-scale-equalizer
barakman
approved these changes
Feb 15, 2024
Lesigh-3100
deleted the
372-incorrect-solidly-factory-abi-used-for-scale-equalizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed handling of factory contract for scale & equalizer