support fusionx v3 on mantle #491
Conversation
| elif self.exchange_name not in [PANCAKESWAP_V3_NAME, AGNI_V3_NAME]: | ||
| return UNISWAP_V3_POOL_ABI | ||
| else: | ||
| return PANCAKESWAP_V3_POOL_ABI |
There was a problem hiding this comment.
not specific to those changes here but this is a case where you should check for all possible conditions and have an else at the end that raises an "unknown exchange"
otherwise errors can percolate much further and may be harder to detect.
Not for now if it goes into the RC but for later
|
I based the branch on develop and it picked up a lot of weird stuff DO NOT MOVE OUT OF DRAFT BEFORE DEALING WITH THIS; talk to me after the RC is out |
You might want to use that branch at the point in time when the RC branch was created, since many more changes have been pushed into it since (starting from around 22nd of March). |
Looking at the diffs I am pretty sure this PR is good. |
zavelevsky
requested review from
mikewcasale
and removed request for
mikewcasale
No description provided.