-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class TxHelpers Revision (April 11) #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2024
Closed
barakman
requested review from
zavelevsky,
platonfloria,
NIXBNT,
sklbancor and
Lesigh-3100
April 11, 2024 20:37
Lesigh-3100
previously requested changes
Apr 15, 2024
… for arb-mode == B3)
zavelevsky
previously approved these changes
Apr 18, 2024
1. Remove (decouple) the dependency on Alchemy's support for this nom-standard request. 2. Reduce the latency of 2 hops to a latency of 1 hop.
barakman
requested review from
zavelevsky
and removed request for
NIXBNT,
sklbancor,
Lesigh-3100 and
platonfloria
April 19, 2024 16:00
zavelevsky
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes, mostly around coding simplification and performance improvements in the
TxHelpers
class, alongside a few related or partially-related cleanups in other modules.The main changes in the
TxHelpers
class are listed below, and only two of them - 1 and 6 - are expected to impact the actual Arb-Behavior of the bot:DEFAULT_GAS_PRICE_OFFSET
constant with agas_strategy
function.maxPriorityFee
via web3 instead of by sending an HTTP request to the node.gasPrice
instead of fetching the entire block in order to retrieve thebaseFee
.accessList
via web3 instead of by sending an HTTP request to the node.EXPECTED_GAS_MODIFIER
constant used for producing an optimistic gas consumption.eth_sendPrivateTransaction
HTTP requests via web3 instead of via the node.tx
dictionary manually and then set itsgas
attribute by callingestimate_gas
, instead of doing both of these things viabuild_transaction
; following that, set theaccessList
attribute in this dictionary, and possibly update itsgas
attribute, by callingcreate_access_list
; the gas-fee attributes (maxFeePerGas
andmaxPriorityFeePerGas
) are set only at the end, in order to avoid getting the "max fee per gas less than block base fee" error.