Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move messages button to the header #55

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Move messages button to the header #55

merged 3 commits into from
Sep 9, 2024

Conversation

wozniaczek123
Copy link
Collaborator

@wozniaczek123 wozniaczek123 commented Sep 8, 2024 •
edited by banocean
Loading

Closes #53

@banocean banocean mentioned this pull request Sep 8, 2024
Closed
banocean
banocean requested changes Sep 8, 2024
View reviewed changes
Copy link
Owner

@banocean banocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in comments, I think it working only with aside open is fair thing, since #36 should introduce api to handle that

patches/messagesButton.js Outdated Show resolved Hide resolved
patches/messagesButton.js Outdated Show resolved Hide resolved
banocean
banocean approved these changes Sep 9, 2024
View reviewed changes
Copy link
Owner

@banocean banocean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. As I said, I'll consider it working only when aside openes (so when someone opens it manually or there is bottom navigation bar patch on) intended and work on that with new api that will be introduced in #36

@banocean banocean merged commit 046a7b1 into banocean:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banocean banocean banocean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brak opcji przełączenia na moduł wiadomości w usprawnionym interfejsie mobilnym.
2 participants
@wozniaczek123 @banocean