This repository has been archived by the owner on Mar 2, 2023. It is now read-only.
Added dynamic bucket region handling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added dynamic bucket region handling.
Why?
To be able to determine the repo bucket's region dynamically without any additional information than the bucket host URL.
Additional context
The solution uses a
HEAD {bucket-host}request which returns the region of the bucket in a response header regardless of the signing region and signing credentials. See aws/aws-sdk-go#720 (comment) where it is confirmed as an officially intended behavior.Checklist
User guide and development docs updated (if needed)Related Helm chart(s) updated (if needed)To Do