Trigger text field #clearErrorMessages on click (#397)

baoagency · Mar 16, 2024 · 720a460 · 720a460
1 parent 4d1cf21
commit 720a460
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/components/polaris/text_field_component.rb b/app/components/polaris/text_field_component.rb
@@ -163,7 +163,7 @@ def input_options
           "Polaris-TextField__Input--suffixed": @suffix.present?
         )
         if @clear_errors_on_focus
-          prepend_option(opts[:data], :action, "focus->polaris-text-field#clearErrorMessages")
+          prepend_option(opts[:data], :action, "click->polaris-text-field#clearErrorMessages")
         end
         prepend_option(opts[:data], :action, "polaris-text-field#syncValue")
       end

diff --git a/test/components/polaris/text_field_component_test.rb b/test/components/polaris/text_field_component_test.rb
@@ -288,7 +288,7 @@ def test_clear_errors_on_focus
       clear_errors_on_focus: true
     ))
 
-    assert_selector "input[name=input_name][data-action~='focus->polaris-text-field#clearErrorMessages']"
+    assert_selector "input[name=input_name][data-action~='click->polaris-text-field#clearErrorMessages']"
 
     render_inline(Polaris::TextFieldComponent.new(
       name: :input_name,
@@ -298,6 +298,6 @@ def test_clear_errors_on_focus
       input_options: {data: {action: "custom#action"}}
     ))
 
-    assert_selector "input[name=input_name][data-action~='focus->polaris-text-field#clearErrorMessages']"
+    assert_selector "input[name=input_name][data-action~='click->polaris-text-field#clearErrorMessages']"
   end
 end