Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "change" event for TextInput's clear button #226

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Add missing "change" event for TextInput's clear button #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/assets/javascripts/polaris_view_components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2402,7 +2402,11 @@ class TextField extends Controller {
this.valueValue = this.inputTarget.value;
}
clear() {
const oldValue = this.value;
this.value = null;
if (this.value != oldValue) {
this.inputTarget.dispatchEvent(new Event("change"));
}
}
increase() {
this.changeNumber(1);
Expand Down
5 changes: 5 additions & 0 deletions app/assets/javascripts/polaris_view_components/text_field_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ export default class extends Controller {
}

clear() {
const oldValue = this.value
this.value = null

if (this.value != oldValue) {
this.inputTarget.dispatchEvent(new Event('change'))
}
}

increase() {
Expand Down