Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust spacing on NavigationList component #347

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Adjust spacing on NavigationList component #347

merged 1 commit into from
Dec 18, 2023

Conversation

forsbergplustwo
Copy link
Collaborator

@forsbergplustwo forsbergplustwo commented Dec 18, 2023 •
edited
Loading

  • Adds more spacing between items
  • Uses css var for Card spacing
  • Adds missing <ul> wrapper HTML

Before:
CleanShot 2023-12-18 at 15 25 18@2x

After:
CleanShot 2023-12-18 at 15 26 35@2x

kirillplatonov
kirillplatonov approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@kirillplatonov kirillplatonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kirillplatonov kirillplatonov merged commit aef9f39 into baoagency:main Dec 18, 2023
4 checks passed
@kirillplatonov
Copy link
Collaborator

@forsbergplustwo @yshmarov I noticed that component has extra left padding. Do we miss some styles in PVC?
CleanShot 2024-01-03 at 13 18 24@2x

@forsbergplustwo
Copy link
Collaborator Author

Thanks for the heads up @kirillplatonov. Will take a look tomorrow 😊

@forsbergplustwo forsbergplustwo mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillplatonov kirillplatonov kirillplatonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forsbergplustwo @kirillplatonov