Skip to content

Commit

Permalink
fix: #1386(github) 逻辑删除字段为Date类型并且非删除数据日期为null
Browse files Browse the repository at this point in the history
  • Loading branch information
yuxiaobin committed Jul 23, 2019
1 parent b5c7eef commit 246b1ec
Show file tree
Hide file tree
Showing 10 changed files with 439 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,34 @@
*/
package com.baomidou.mybatisplus.core.metadata;

import static java.util.stream.Collectors.joining;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.function.Predicate;

import org.apache.ibatis.mapping.ResultFlag;
import org.apache.ibatis.mapping.ResultMap;
import org.apache.ibatis.mapping.ResultMapping;
import org.apache.ibatis.session.Configuration;

import com.baomidou.mybatisplus.annotation.IdType;
import com.baomidou.mybatisplus.annotation.KeySequence;
import com.baomidou.mybatisplus.core.MybatisConfiguration;
import com.baomidou.mybatisplus.core.toolkit.*;
import com.baomidou.mybatisplus.core.toolkit.Assert;
import com.baomidou.mybatisplus.core.toolkit.CollectionUtils;
import com.baomidou.mybatisplus.core.toolkit.Constants;
import com.baomidou.mybatisplus.core.toolkit.ExceptionUtils;
import com.baomidou.mybatisplus.core.toolkit.StringUtils;
import com.baomidou.mybatisplus.core.toolkit.sql.SqlScriptUtils;

import lombok.AccessLevel;
import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.experimental.Accessors;
import org.apache.ibatis.mapping.ResultFlag;
import org.apache.ibatis.mapping.ResultMap;
import org.apache.ibatis.mapping.ResultMapping;
import org.apache.ibatis.session.Configuration;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.function.Predicate;

import static java.util.stream.Collectors.joining;

/**
* 数据库表反射信息
Expand Down Expand Up @@ -331,9 +337,7 @@ public String getLogicDeleteSql(boolean startWithAnd, boolean deleteValue) {
if (logicDelete) {
TableFieldInfo field = fieldList.stream().filter(TableFieldInfo::isLogicDelete).findFirst()
.orElseThrow(() -> ExceptionUtils.mpe("can't find the logicFiled from table {%s}", tableName));
String formatStr = field.isCharSequence() ? "'%s'" : "%s";
String logicDeleteSql = field.getColumn() + EQUALS +
String.format(formatStr, deleteValue ? field.getLogicDeleteValue() : field.getLogicNotDeleteValue());
String logicDeleteSql = formatLogicDeleteSql(field, deleteValue);
if (startWithAnd) {
logicDeleteSql = " AND " + logicDeleteSql;
}
Expand All @@ -342,6 +346,23 @@ public String getLogicDeleteSql(boolean startWithAnd, boolean deleteValue) {
return EMPTY;
}

/**
* format logic delete SQL, can be overrided by subclass
* github #1386
*
* @param field TableFieldInfo
* @param deleteValue true: logicDeleteValue, false: logicNotDeleteValue
* @return
*/
protected String formatLogicDeleteSql(TableFieldInfo field, boolean deleteValue) {
String value = deleteValue ? field.getLogicDeleteValue() : field.getLogicNotDeleteValue();
if (NULL.equalsIgnoreCase(value)) {
return field.getColumn() + " is NULL";
} else {
return field.getColumn() + EQUALS + String.format(field.isCharSequence() ? "'%s'" : "%s", value);
}
}

/**
* 自动构建 resultMap 并注入(如果条件符合的话)
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,41 @@
*/
package com.baomidou.mybatisplus.test.h2;

import java.util.List;

import javax.annotation.Resource;

import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.test.annotation.DirtiesContext;

import com.baomidou.mybatisplus.test.h2.entity.H2User;
import com.baomidou.mybatisplus.test.h2.enums.AgeEnum;

@DirtiesContext
public class BaseTest {

@Resource
protected JdbcTemplate jdbcTemplate;

protected static final String NQQ = "聂秋秋";

protected void log(Object object) {
System.out.println(object);
}

protected List<H2User> queryByName(String name) {
String sql = "select TEST_ID, NAME, AGE,LAST_UPDATED_DT from h2user ";
if (name != null) {
sql += "where name='" + name + "'";
}
return jdbcTemplate.query(sql, (rs, rowNum) -> {
H2User u = new H2User();
u.setTestId(rs.getLong("TEST_ID"));
u.setName(rs.getString("NAME"));
u.setAge(AgeEnum.parseValue(rs.getInt("AGE")));
u.setLastUpdatedDt(rs.getDate("LAST_UPDATED_DT"));
return u;
});
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@
*/
package com.baomidou.mybatisplus.test.h2;

import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import com.baomidou.mybatisplus.test.h2.enums.AgeEnum;
import com.baomidou.mybatisplus.test.h2.mapper.H2StudentMapper;
import com.baomidou.mybatisplus.test.h2.mapper.H2UserMapper;
import com.baomidou.mybatisplus.test.h2.entity.H2Student;
import com.baomidou.mybatisplus.test.h2.entity.H2User;
import java.util.List;

import javax.annotation.Resource;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
Expand All @@ -29,7 +28,12 @@
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit.jupiter.SpringExtension;

import javax.annotation.Resource;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import com.baomidou.mybatisplus.test.h2.entity.H2Student;
import com.baomidou.mybatisplus.test.h2.entity.H2User;
import com.baomidou.mybatisplus.test.h2.enums.AgeEnum;
import com.baomidou.mybatisplus.test.h2.mapper.H2StudentMapper;
import com.baomidou.mybatisplus.test.h2.mapper.H2UserMapper;

/**
* Mybatis Plus H2 Junit Test
Expand Down Expand Up @@ -64,7 +68,7 @@ void crudTest() {
for (long i = 0; i < 10L; i++) {
defaultMapper.insert(new H2Student(i, "Tom长大了", 1));
}
log(logicDeleteMapper.selectList(new QueryWrapper<>(h2User).eq("name","2").orderByAsc("name")));
log(logicDeleteMapper.selectList(new QueryWrapper<>(h2User).eq("name", "2").orderByAsc("name")));
log(defaultMapper.selectList(new QueryWrapper<H2Student>().orderByAsc("id")));
log(defaultMapper.selectOne(new QueryWrapper<H2Student>().last("limit 1")));

Expand All @@ -79,5 +83,9 @@ void crudTest() {
void delete() {
logicDeleteMapper.delete(new QueryWrapper<>());
defaultMapper.delete(new QueryWrapper<>());
Assertions.assertEquals(0, (int) logicDeleteMapper.selectCount(new QueryWrapper<>()));
List<H2User> userList = queryByName(null);
System.out.println(userList.size());
Assertions.assertNotEquals(0, userList.size());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright (c) 2011-2019, hubin ([email protected]).
* <p>
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
* <p>
* https://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.baomidou.mybatisplus.test.h2;

import java.util.List;

import javax.annotation.Resource;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.MethodOrderer;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestMethodOrder;
import org.junit.jupiter.api.extension.ExtendWith;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit.jupiter.SpringExtension;

import com.baomidou.mybatisplus.test.h2.entity.H2User;
import com.baomidou.mybatisplus.test.h2.entity.H2UserLogicDelete;
import com.baomidou.mybatisplus.test.h2.enums.AgeEnum;
import com.baomidou.mybatisplus.test.h2.mapper.H2UserLogicDeleteMapper;

/**
* Mybatis Plus H2 Junit Test
*
* @author hubin
* @since 2018-06-05
*/
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
@ExtendWith(SpringExtension.class)
@ContextConfiguration(locations = {"classpath:h2/spring-logic-delete-h2.xml"})
class H2LogicDeleteTest extends BaseTest {

@Resource
protected H2UserLogicDeleteMapper logicDeleteMapper;

@Test
@Order(1)
void crudTest() {
String name = "LogicDelete4Date";
H2UserLogicDelete user = new H2UserLogicDelete();
user.setAge(AgeEnum.ONE);
user.setName(name);
logicDeleteMapper.insert(user);
Assertions.assertNotNull(user.getTestId(), "id should not be null");
Assertions.assertNull(user.getLastUpdatedDt());

logicDeleteMapper.deleteById(user.getTestId());

List<H2User> userList = queryByName(name);
Assertions.assertTrue(userList!=null && !userList.isEmpty());
Assertions.assertNotNull(userList.get(0).getLastUpdatedDt(),"lastUpdateDt should not be null after logic delete");

}

}
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,21 @@
*/
package com.baomidou.mybatisplus.test.h2.config;

import java.io.IOException;

import javax.sql.DataSource;

import org.h2.Driver;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.io.support.PathMatchingResourcePatternResolver;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.datasource.DataSourceTransactionManager;
import org.springframework.jdbc.datasource.SimpleDriverDataSource;
import org.springframework.jdbc.datasource.init.DataSourceInitializer;
import org.springframework.jdbc.datasource.init.DatabasePopulator;
import org.springframework.jdbc.datasource.init.ResourceDatabasePopulator;
import org.springframework.transaction.annotation.EnableTransactionManagement;
import java.io.IOException;

/**
* H2 Memory Database config
Expand Down Expand Up @@ -71,4 +74,9 @@ private DatabasePopulator databasePopulator() throws IOException {
return resourceDatabasePopulator;
}

@Bean
public JdbcTemplate jdbcTemplate(DataSource ds){
return new JdbcTemplate(ds);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
/*
* Copyright (c) 2011-2020, baomidou ([email protected]).
* <p>
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
* <p>
* https://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.baomidou.mybatisplus.test.h2.config;

import javax.sql.DataSource;

import org.apache.ibatis.plugin.Interceptor;
import org.apache.ibatis.session.ExecutorType;
import org.apache.ibatis.session.SqlSessionFactory;
import org.apache.ibatis.type.EnumOrdinalTypeHandler;
import org.apache.ibatis.type.JdbcType;
import org.mybatis.spring.annotation.MapperScan;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.io.ResourceLoader;

import com.baomidou.mybatisplus.annotation.IdType;
import com.baomidou.mybatisplus.core.MybatisConfiguration;
import com.baomidou.mybatisplus.core.config.GlobalConfig;
import com.baomidou.mybatisplus.extension.injector.LogicSqlInjector;
import com.baomidou.mybatisplus.extension.plugins.OptimisticLockerInterceptor;
import com.baomidou.mybatisplus.extension.plugins.PaginationInterceptor;
import com.baomidou.mybatisplus.extension.plugins.PerformanceInterceptor;
import com.baomidou.mybatisplus.extension.spring.MybatisSqlSessionFactoryBean;

/**
* Mybatis Plus Config
*
* @author Caratacus
* @since 2017/4/1
*/
@Configuration
@MapperScan("com.baomidou.mybatisplus.test.h2.mapper")
public class MybatisPlusConfigLogicDelete {

@Bean("mybatisSqlSession")
public SqlSessionFactory sqlSessionFactory(DataSource dataSource, ResourceLoader resourceLoader, GlobalConfig globalConfig) throws Exception {
MybatisSqlSessionFactoryBean sqlSessionFactory = new MybatisSqlSessionFactoryBean();
sqlSessionFactory.setDataSource(dataSource);
// sqlSessionFactory.setConfigLocation(resourceLoader.getResource("classpath:mybatis-config-object-factory.xml"));
sqlSessionFactory.setTypeAliasesPackage("com.baomidou.mybatisplus.test.h2.entity.persistent");
MybatisConfiguration configuration = new MybatisConfiguration();
// configuration.setDefaultScriptingLanguage(MybatisXMLLanguageDriver.class);
// org.apache.ibatis.session.Configuration configuration = new org.apache.ibatis.session.Configuration();
configuration.setJdbcTypeForNull(JdbcType.NULL);
/*
* 下划线转驼峰开启
*/
configuration.setMapUnderscoreToCamelCase(true);
configuration.setDefaultExecutorType(ExecutorType.REUSE);
configuration.setDefaultEnumTypeHandler(EnumOrdinalTypeHandler.class); //默认枚举处理
sqlSessionFactory.setConfiguration(configuration);
PaginationInterceptor pagination = new PaginationInterceptor();
OptimisticLockerInterceptor optLock = new OptimisticLockerInterceptor();
sqlSessionFactory.setPlugins(new Interceptor[]{
pagination,
optLock,
new PerformanceInterceptor()
});
sqlSessionFactory.setGlobalConfig(globalConfig);
sqlSessionFactory.setTypeEnumsPackage("com.baomidou.mybatisplus.test.h2.enums");
return sqlSessionFactory.getObject();
}

@Bean
public GlobalConfig globalConfiguration() {
GlobalConfig conf = new GlobalConfig();
conf.setSqlInjector(new LogicSqlInjector())
.setEnableSqlRunner(true)
.setDbConfig(new GlobalConfig.DbConfig()
.setLogicDeleteValue("NOW()")
.setLogicNotDeleteValue("NULL")
.setIdType(IdType.ID_WORKER));
return conf;
}
}
Loading

0 comments on commit 246b1ec

Please sign in to comment.