Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does arch get included in the cache key? #24

Closed
max-sixty opened this issue Mar 28, 2024 · 2 comments
Closed

Does arch get included in the cache key? #24

max-sixty opened this issue Mar 28, 2024 · 2 comments

Comments

@max-sixty
Copy link

Thanks a lot for offering this, I've found it the simplest and best way to get crates installed!


We've recently started seeing some failures in our jobs. We run jobs on both macos-14, which using aarch64 and macos-latest, which uses x86. (So 14 is actually more recent than latest...)

It looks like the cache key is the same for both, even though the binaries aren't compatible:

  • macos-14 job: key: cargo-install-cargo-insta-1.38.0-a4f6b43f6bcdf44918ef
  • macos-latest job: key: cargo-install-cargo-insta-1.38.0-a4f6b43f6bcdf44918ef

We then get an error Bad CPU type in executable (os error 86), ref PRQL/prql#4362

It looks like this should be covered by #20; any ideas why the key seems to be the same?

@baptiste0928
Copy link
Owner

Thanks for reporting this, the os version wasn't being run on mac because I was checking the os name against MacOS instead of macOS ( 😅 ). I fixed this and also included the os arch explicitly in the cache key.

I will publish a new version with these fixes.

@max-sixty
Copy link
Author

Thanks @baptiste0928 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants