Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Upgrade to typescript 2.8 #67

Closed
scharf opened this issue Dec 22, 2017 · 10 comments
Closed

Upgrade to typescript 2.8 #67

scharf opened this issue Dec 22, 2017 · 10 comments

Comments

@scharf
Copy link

scharf commented Dec 22, 2017

The current version (2.5.3) is almost 3 months old. What about an upgrade to 2.6.2

@mattmccutchen
Copy link

Keeping up with TypeScript is going to be a pain. Is there any way the build plugin could use a copy of TypeScript installed as an app-level NPM package?

In the meantime, it's possible (but a big hassle) to fork barbatus:typescript and barbatus:typescript-compiler as local packages, make a local copy of the meteor-typescript NPM package, change the version there, and change the local barbatus:typescript-compiler to point to the local meteor-typescript via a file:/// URL.

@scharf scharf changed the title Upgrade to typescript 2.6 Upgrade to typescript 2.7 Feb 1, 2018
@scharf
Copy link
Author

scharf commented Feb 1, 2018

Since 2.7 is out, I changed the title from 2.6 to 2.7

@scharf
Copy link
Author

scharf commented Mar 27, 2018

Since 2.8 is out, I changed the title from 2.7 to 2.8...

@scharf scharf changed the title Upgrade to typescript 2.7 Upgrade to typescript 2.8 Mar 27, 2018
@Rhywden
Copy link

Rhywden commented Mar 31, 2018

Hey, just an FYI: Since for some reason Barbatus is away I've finally decided to at least try to update TypeScript to the latest version by simply plonking new versions everywhere.
I don't promise wonders, new features or that it won't blow up in my face.
As such, I'm indeed forking the whole shebang but six months are a bit of a bad sign.

@scharf
Copy link
Author

scharf commented Apr 5, 2018

@andrei-markeev
Copy link

andrei-markeev commented Apr 27, 2018

TypeScript 2.8 introduced some really cool new features, like mapped and conditional types for example, so would be really great if Meteor also supported latest version of TS.

I was wondering, is it actually possible to use the TS installed in the system instead of TS embedded in the package? Maybe some switch for this... This would solve necessity to regularly update TS version in the package...

@mattmccutchen
Copy link

I was wondering, is it actually possible to use the TS installed in the system instead of TS embedded in the package?

Then you would lose reproducibility. It would be better to use an app-level NPM package.

@andrei-markeev
Copy link

andrei-markeev commented May 1, 2018

Then you would lose reproducibility. It would be better to use an app-level NPM package.

Yep you're right, I agree that project-scope npm package is actually better. I'm working with Meteor mostly on hobby projects so didn't think about projects where many developers are working.

Now that I think of it, it seems to be exactly as with this annoying @babel/runtime dependency, so probably can be implemented in similar way as the babel-compiler package. And would be cool if it would actually replace babel-compiler (if you opt for typescript), because I think ts can do everything what babel can do anyway.

Btw, was really tired of seeing tons of errors during compilation because of old version of ts, and as a temporary fix, updated "C:\Users%username%\AppData\Local.meteor\packages\barbatus_typescript-compiler\0.9.12\npm\node_modules\meteor-typescript\package.json" (note: you might have different version than 0.9.12, and of course different path to .meteor if you're on Mac or Linux)

with

"typescript": "^2.8.1",

and now it works on my machine 😄

@barbatus
Copy link
Owner

Upgraded to 2.8.3. Please make sure it works for you

@scharf
Copy link
Author

scharf commented May 26, 2018

Thank you very much!

@scharf scharf closed this as completed May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants