Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dados] br_cgu_cartao_pagamento #865

Merged
merged 17 commits into from
Oct 17, 2024
Merged

Conversation

tricktx
Copy link
Collaborator

@tricktx tricktx commented Sep 12, 2024

No description provided.

@tricktx tricktx requested a review from a team September 12, 2024 20:13
@tricktx tricktx self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Coverage

Tests Skipped Failures Errors Time
8 7 💤 0 ❌ 0 🔥 8.598s ⏱️

@tricktx
Copy link
Collaborator Author

tricktx commented Sep 13, 2024

Eu tinha esquecido de colocar como draft, mas ainda não estava pronto para reviews. Subi para o github para deixar as alterações salvas e porque parece que meu pc está morrendo.

Irei consertar os comentários, obrigado.
@laura-l-amaral

@tricktx tricktx marked this pull request as draft September 13, 2024 13:38
@laura-l-amaral laura-l-amaral linked an issue Sep 16, 2024 that may be closed by this pull request
@tricktx tricktx marked this pull request as ready for review September 18, 2024 15:34
"dbt_alias": True,
"historical_data": False,
"update_metadata": True,
"year" : constants_cgu.year.value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o schedule não deve ter ano e mes

}

year = datetime.now().year
month = datetime.now().month
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o arquivo de constantes deve conster apenas constantes, não funções

"OUTPUT_DATA" : "/tmp/output/microdados_defesa_civil",
"URL" : "https://portaldatransparencia.gov.br/download-de-dados/cpdc/",
"READ" : "_CPDC",
"UNICO" : False}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq tem esse parametro de UNICO se o único valor que ele tem é False?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como é um crawler, o objetivo é ser abrangente.
Há conjuntos do cgu são únicos e não são dividido por ano/mês, criei esse parâmetro que conseguimos diferenciar o formato e dessa forma, rodar o download.

@tricktx tricktx marked this pull request as draft September 19, 2024 22:52
@tricktx tricktx marked this pull request as ready for review October 9, 2024 15:32
@tricktx tricktx added the hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest label Oct 17, 2024
@tricktx tricktx merged commit 01531a4 into main Oct 17, 2024
7 checks passed
@tricktx tricktx deleted the staging/br_cgu_cartao_pagamento branch October 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[add] br_cgu_cartao_pagamento
2 participants