Pass nREPL client evaled code's line and col nums to the reader

[ikappaki]

Hi,

could you please consider patch to pass the nREPL client's eval file line and column numbers down to the reader for more accurate compiler exception reporting. It fixes #1037.

I have attempted a focused approach to propagate the line and column parameters to the error reporting mechanism. If this approach is not optimal, I am open to reorganizing the code based on better suggestions.

I've included tests down the affected path to cover these changes.

Thanks

[chrisrink10]

Makes sense to me. My main comments are just around the naming of the kwargs and a few stylistic things with the documentation.

[chrisrink10]

Suggested change

	(client-send! client {:id (id-inc!) :ns "abc.xyz":op "eval" :code "(abc)"
	:file filename
	:line 6 :column 2})
	(client-send! client {:id (id-inc!) :ns "abc.xyz" :op "eval" :code "(abc)"
	:file filename
	:line 6 :column 2})

I guess I wouldn't hate if this was each key on its own line, but if not then can you at least add a space between this string and keyword.

[ikappaki]

Updated to add a space. Apologies for not placing each key on its own line; the rest of the test file follows an ad-hoc style for (my) visual clarity and space conservation, which might seem inconsistent otherwise. Perhaps we could look into a tool similar to black in Python for automatic code formatting?

One tool that comes to mind is cljfmt, which could have caught this with its :insert-missing-whitespace? option and even better would have split the keys into their own lines using :split-keypairs-over-multiple-lines?.

[chrisrink10]

I like the idea and as you know I've configured formatting checks for the Python code. However, I recently surveyed the Clojure formatting tool space for just this purpose and found myself unsatisfied with any of the options. I primarily write Clojure in Emacs (Spacemacs) and have always found that I prefer its implicit formatting style (with alignment), but none of the tools would enforce that style for me without other drawbacks or difficulties.

[ikappaki]

I like the idea and as you know I've configured formatting checks for the Python code.

Indeed, this is why I mentioned it. It's very useful.

I primarily write Clojure in Emacs (Spacemacs) and have always found that I prefer its implicit formatting style (with alignment), but none of the tools would enforce that style for me without other drawbacks or difficulties.

Out of curiosity, which specific alignment setting do you find missing in cljfmt? It seems fairly configurable, or is it more the overall alignment style that’s tricky to set up?