Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper CI (github workflows?) #3

Closed
saemideluxe opened this issue Jan 5, 2021 · 1 comment · Fixed by #6
Closed

Add proper CI (github workflows?) #3

saemideluxe opened this issue Jan 5, 2021 · 1 comment · Fixed by #6
Assignees

Comments

@saemideluxe
Copy link
Member

saemideluxe commented Jan 5, 2021

Things needed to do:

  • black formatting
  • flake8 checks
  • isort (ordering import statements)
  • bandit (dependency vulnerability checks)
  • run tests and coverage
  • update pip package if there is a new release
@tpokorra tpokorra self-assigned this Jan 6, 2021
@tpokorra
Copy link
Member

tpokorra commented Jan 11, 2021

Github offers CI services for free for open projects.
"GitHub Actions is available with GitHub Free, GitHub Pro, GitHub Free for organizations, GitHub Team, GitHub Enterprise Cloud, GitHub Enterprise Server, and GitHub One. GitHub Actions is not available for private repositories owned by accounts using legacy per-repository plans."
see https://docs.github.com/en/free-pro-team@latest/actions/guides/about-continuous-integration

see https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-python
with flake8.

black formatting: https://github.com/marketplace/actions/black-code-formatter
and https://github.com/psf/black/actions/runs/17913292/workflow

isort: https://pypi.org/project/isort/
need to use black profile for isort: PyCQA/isort#1518

bandit: https://pypi.org/project/bandit/

don't fail the pytest if there are no tests:
pytest-dev/pytest#2393
https://pypi.org/project/pytest-custom-exit-code/

tpokorra added a commit that referenced this issue Jan 11, 2021
tpokorra added a commit that referenced this issue Jan 11, 2021
tpokorra added a commit that referenced this issue Jan 11, 2021
tpokorra added a commit that referenced this issue Jan 11, 2021
tpokorra added a commit that referenced this issue Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants