Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #1855: "All Bazel commands fail when changing a Go dependency when using Bzlmod extension" #1860

Closed
wants to merge 1 commit into from
Closed

Fix Issue #1855: "All Bazel commands fail when changing a Go dependency when using Bzlmod extension" #1860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/bzlmod/go_deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,11 +632,16 @@ def _go_deps_impl(module_ctx):
"local_path": module.local_path,
})
else:
go_repository_args.update({
"sum": _get_sum_from_module(path, module, sums),
repo_args = {
"replace": getattr(module, "replace", None),
"version": "v" + module.raw_version,
})
}

sum = _get_sum_from_module(path, module, sums)
if sum:
repo_args["sum"] = sum

go_repository_args.update(repo_args)

go_repository(**go_repository_args)

Expand Down Expand Up @@ -689,7 +694,10 @@ def _get_sum_from_module(path, module, sums):
# replacement have no sums, so we can skip this
return None
elif module.local_path == None:
fail("No sum for {}@{} from {} found. You may need to run: bazel run @rules_go//go -- mod tidy".format(path, module.raw_version, "parent-label-todo")) #module.parent_label))
# When updating a dependency, its sum may not be in go.sum and we can't hard fail here
# since we need Bazel to tidy the module
print("No sum for {}@{} found, run bazel run @rules_go//go -- mod tidy to generate it".format(path, module.raw_version)) #module.parent_label))
return None

return sums[entry]

Expand Down