Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not revalidate glob expressions on each invocation #1964

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Oct 21, 2024

doublestar now has an option to match without re-validating every time, see bmatcuk/doublestar#92

What type of PR is this?

Other

What package or component does this PR mostly affect?

all

What does this PR do? Why is it needed?

Performance

@jbedard jbedard force-pushed the doublestar82-perf branch 3 times, most recently from ce38049 to 208e0fb Compare October 21, 2024 20:20
@fmeum fmeum merged commit 2a84bad into bazel-contrib:master Oct 21, 2024
14 checks passed
@jbedard jbedard deleted the doublestar82-perf branch October 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants