Use actual newline (instead of "\n") to split strings in yq rule #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes d79f4d4 Fixes #463 This is required since versions of yq older than 4.30.3 do not parse "\n" correctly. See mikefarah/yq#1430 and e02bb7194897edb916a6787fb8f8e5a7f432dd94
opicaud
approved these changes
Jun 22, 2023
|
Wow that was silly. I was debugging this to fix it myself, and stumbled on this thread without realizing it's a PR on bazel-lib :) |
alexeagle
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes d79f4d4
Fixes #463
This is required since versions of yq older than 4.30.3 do not parse "\n" correctly. See mikefarah/yq#1430 and mikefarah/yq@e02bb71
Type of change
Test plan
bazel build //lib/tests/yq:stampedcat bazel-bin/lib/tests/yq/_stamped_stamp.yamlWithout this fix, the file only contains the first item of
bazel-out/stable-status.txtandbazel-out/volatile-status.txtrespectively. With the fix, every item appears in the yaml.