feat: add is_bazel_7_or_greater utility function to public API #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
|
Oops we probably should have added a dep on bazel_features when we did the 2.0 |
alexeagle
reviewed
Jan 8, 2024
alexeagle
approved these changes
Jan 8, 2024
gregmagolan
added a commit
that referenced
this pull request
Jan 8, 2024
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future we should make detection of the Bazel version part of the public API of bazel_features and use that.
Currently, however, the bazel version comparison functions in bazel_features are private API so a change needs to be made there to make the public API. Also adding a new non-dev dep on bazel_features here would be breaking for WORKSPACE users which is undesirable atm.
Type of change
Test plan