Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: align ci patterns #843

Merged
merged 1 commit into from
May 14, 2024
Merged

chore: align ci patterns #843

merged 1 commit into from
May 14, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented May 14, 2024 •
edited
Loading

Lots of cleanup of our CI and bazelrc patterns here. Aligns these patterns with our other rulesets. No functional changes.

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented May 14, 2024 •
edited
Loading

Test

All tests were cache hits

215 tests (100.0%) were fully cached saving 46s.

Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.

Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 455ms.

Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the align_ci_patterns__windows__macos branch 3 times, most recently from 0c8d48d to a3798a9 Compare May 14, 2024 05:07
@gregmagolan gregmagolan marked this pull request as ready for review May 14, 2024 05:08
@gregmagolan gregmagolan requested a review from jbedard May 14, 2024 05:08
@gregmagolan gregmagolan force-pushed the align_ci_patterns__windows__macos branch 2 times, most recently from 37d7495 to bd99964 Compare May 14, 2024 05:23
@gregmagolan
Copy link
Collaborator Author

gregmagolan commented May 14, 2024 •
edited
Loading

With the bump to Bazel 7.1.2 we're now getting strange go stdlib cgo looking failures on 3 e2e tests but only on Workflows runners and not on GHA which is running the same thing

  • ci/circleci: aw-e2e_copy_to_directory_test — Your tests failed on CircleCI
    Details
  • ci/circleci: aw-e2e_external_copy_to_directory_test — Your tests failed on CircleCI
    Details
  • ci/circleci: aw-e2e_smoke_test — Your tests failed on CircleCI
    Details

Will keep investigating tomorrow...

@gregmagolan gregmagolan force-pushed the align_ci_patterns__windows__macos branch 3 times, most recently from 195a757 to 1e8a928 Compare May 14, 2024 06:21
@gregmagolan gregmagolan mentioned this pull request May 14, 2024
Merged
@gregmagolan gregmagolan force-pushed the align_ci_patterns__windows__macos branch from 1e8a928 to 59a7c83 Compare May 14, 2024 06:31
@gregmagolan gregmagolan force-pushed the align_ci_patterns__windows__macos branch from 59a7c83 to 4f3079f Compare May 14, 2024 06:33
@gregmagolan
Copy link
Collaborator Author

Will keep investigating tomorrow...

Figured it out: 7c958d6

@gregmagolan gregmagolan enabled auto-merge (squash) May 14, 2024 06:38
@gregmagolan gregmagolan merged commit ffc5a7b into main May 14, 2024
60 checks passed
@gregmagolan gregmagolan deleted the align_ci_patterns__windows__macos branch May 14, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard