Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: detect stardoc output change #75

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: detect stardoc output change #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f45ac8
feat: detect stardoc output change
alexeagle Oct 2, 2024
cde7c40
Update features.bzl
alexeagle Oct 2, 2024
3e529fc
Update features.bzl
alexeagle Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion features.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Defines all the features this module supports detecting."""

load("@bazel_features_globals//:globals.bzl", "globals")
load("//private:util.bzl", "ge", "ge_same_major", "lt")
load("//private:util.bzl", "ge", "ge_same_major", "gt", "lt")

_cc = struct(
# Whether @bazel_tools//tools/cpp:optional_current_cc_toolchain and the `mandatory` parameter
Expand Down Expand Up @@ -33,6 +33,12 @@ _cc = struct(
protobuf_on_allowlist = ge("8.0.0"),
)

_docs = struct(
# The stardoc output changed in https://github.com/bazelbuild/bazel/commit/bd1c3af2ea14e81268e940d2b8ba5ad00c3f08d7
# This may be required for "diff tests" that assert on the generated API docs.
fmeum marked this conversation as resolved.
Show resolved Hide resolved
kwargs_name_with_double_star = ge("8.0.0-pre.20240603.2"),
)

_external_deps = struct(
# Whether --enable_bzlmod is set, and thus, whether str(Label(...)) produces canonical label
# literals (i.e., "@@repo//pkg:file").
Expand Down Expand Up @@ -98,6 +104,7 @@ _toolchains = struct(

bazel_features = struct(
cc = _cc,
docs = _docs,
external_deps = _external_deps,
flags = _flags,
globals = globals,
Expand Down