Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use use_default_shell_env whenever possible #2723

Closed
wants to merge 1 commit into from

Conversation

mrmeku
Copy link

@mrmeku mrmeku commented Nov 18, 2020

What type of PR is this?

Uncomment one line below and remove others.

Bug fix

What does this PR do? Why is it needed?
This PR makes all actions use use_default_shell_env when possible.
This change is needed to increase the likelyhood of cache hits from rule_go actions

Fixes #1531

@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@jayconrod
Copy link
Contributor

Sorry, I can't accept this. use_default_shell_env makes actions less hermetic and less likely to be cached. It should only be used when an external tool needs to be invoked with custom flags, or when an internal toolchain can't be configured correctly. #1531 definitely doesn't justify this.

@jayconrod jayconrod closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdlib not being cached on remote server
2 participants