Add output of bindata rule to runfiles

[gregmagolan]

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

The DefaultInfo provided by the bindata rule doesn't put its output in runfiles.

A binary rule such as an sh_binary that adds on the output of bindata to its data would expect the output to be found at $(rootpath :bindata_target).

For example,

sh_binary(
    name = "bin_target",
    srcs = ["script.sh"],
    data = [":bindata_target"],
    args = ["$(rootpath :bindata_target)"],
)

Which issues(s) does this PR fix?

None filed

Other notes for review

[robfig]

Thanks for the fix! Is it feasible to augment the bindata test in tests/legacy/examples/bindata/ so that it would detect this problem, to avoid regressions?

[fmeum]

Just as a side remark: This behavior of the native rules, which is inconsistent with the recommended behavior for Starlark rules, will be fixed with bazelbuild/bazel#15052. But this PR is still a good workaround in the meantime.

[fmeum]

bindata is deprecated and marked for removal in 0.39.0. Going forward, embedsrcs is the recommended way to embed files backed by //go:embed.

The underlying issue in Bazel is fixed in 6.0.0.