revert the upgrade of googleapis #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Nov 23, 2022
linzhp
added a commit
to linzhp/rules_go
that referenced
this pull request
Nov 28, 2022
This reverts commit 83d85a8.
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
googleapis recently change the storage.proto from non-optional to optional: googleapis/googleapis@844d0f7#diff-2660f693fda035ec39d894e812a519cc57f7dd396868c32b7d5e1dbc9bfce6a8L1726-R1773
The resulting Go code changes from
int64to*int64, breaking all its callers. We need to hold on to this upgrade a bit.Other notes for review