releaser: turn off upload to mirror by default #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually think that none of us have access. Thanks for the cleanup! Could you also update the wiki page on releases? |
fmeum
approved these changes
Sep 5, 2023
|
Not quite sure why CI failed. Looks unrelated to the change?
I updated it just now. No need to wait for release as no manual mirroring should be done here :P |
|
GitHub Actions and seemingly also code downloads are experiencing issues, I will retry later. |
sluongng
added a commit
to sluongng/rules_go
that referenced
this pull request
Sep 5, 2023
Upgrade was done with ```bash > bazel run go/tools/releaser -- upgrade-dep org_golang_x_tools ``` after the patch in bazel-contrib#3677. --- A few additional updates needed for this to work: - Update to `tests/integration/popular_repos` to remove unused packages - Update to `nogo` to use the new interface of x/tools Because this upgrade is NOT backward compatible (by design of x/tools repo), downstream users of rules_go are advised to upgrade `x/tools` version in their repo to v0.12.0 or later to avoid breakages.
sluongng
added a commit
to sluongng/rules_go
that referenced
this pull request
Sep 5, 2023
Upgrade was done with ```bash > bazel run go/tools/releaser -- upgrade-dep org_golang_x_tools ``` after the patch in bazel-contrib#3677. --- A few additional updates needed for this to work: - Update to `tests/integration/popular_repos` to remove unused packages - Update to `nogo` to use the new interface of x/tools Because this upgrade is NOT backward compatible (by design of x/tools repo), downstream users of rules_go are advised to upgrade `x/tools` version in their repo to v0.12.0 or later to avoid breakages.
Most rules_go maintainers do not have direct access to Bazel team's GSC bucket to upload this mirror. Let's disable it by default for eventually removal. Mirroring should be done by filing a requests in Bazel.git's Github issues.
fmeum
force-pushed
the
sluongng/releaser-no-gsutil
branch
from
8b1ef41
to
e9295ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most rules_go maintainers do not have direct access to Bazel team's
GSC bucket to upload this mirror. Let's disable it by default for
eventually removal.
Mirroring should be done by filing a requests in Bazel.git's Github
issues.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review