-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gopackagesdriver): add base test case for go packages driver #3743
feat(gopackagesdriver): add base test case for go packages driver #3743
Conversation
Thank you very much, this was sorely lacking! Just mention me when you think this is ready. CI is unfortunately still failing. |
Thanks yeah, it was passing locally so I'll investigate today! |
Ready to be reviewed @fmeum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you very much!
The bug fixes may even end up resolving some open issues.
75f3df7
to
f1fe653
Compare
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715) - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716) - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720) - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724) - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722) - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730) - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725) - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744) - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747) - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748) - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743) - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750) - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751) - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745) #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) **Full Changelog**: bazel-contrib/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715) - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716) - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720) - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724) - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722) - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730) - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725) - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744) - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747) - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748) - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743) - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750) - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751) - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745) #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) **Full Changelog**: bazel-contrib/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.42.0` -> `v0.43.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0) #### Breaking `x/tools` upgrade This change includes a breaking upgrade to [golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools) Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure compatibility with rules_go's NoGo. **If you need to use an older version of `x/tools` (`v0.13.0` or earlier), apply the following patch to `rules_go`**: [x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch) #### What's Changed - Test BCR test module on macos_arm64 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715) - update documentation for `0.42.0` release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716) - add netrc support to go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - Temporarily disable Bzlmod explicitly by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720) - Fix urls used to get auth in go_download_sdk by [@​justinwon777](https://togithub.com/justinwon777) in [https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724) - Include `go.env` in `//go` runfiles by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722) - Update arm platform constraint to latest value in bazel. by [@​BryanDClark](https://togithub.com/BryanDClark) in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - Add toolchain param to affected actions by [@​kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - upgrade tools by [@​hawkingrei](https://togithub.com/hawkingrei) in [https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730) - Also take library deps like srcs into account in go context by [@​mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725) - Add go_cross_binary to README by [@​jfirebaugh](https://togithub.com/jfirebaugh) in [https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744) - Update `bazel_features` to v1.1.1 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747) - builder: Make paths absolute for stdliblist ([#​1357](https://togithub.com/bazelbuild/rules_go/issues/1357)) by [@​zecke](https://togithub.com/zecke) in [https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748) - feat(gopackagesdriver): add base test case for go packages driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743) - Fix bazel query scope not being used by [@​rastenis](https://togithub.com/rastenis) in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - Add support for `xtest` packages in Go Packages Driver by [@​JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750) - upgrade x/tools to 0.15.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751) - bug fix: parse embeds in files that contain the double quote rune by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) - prepare release 0.43.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745) #### New Contributors - [@​justinwon777](https://togithub.com/justinwon777) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718) - [@​BryanDClark](https://togithub.com/BryanDClark) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734) - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740) - [@​rastenis](https://togithub.com/rastenis) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688) - [@​andyscott](https://togithub.com/andyscott) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672) **Full Changelog**: bazel-contrib/rules_go@v0.42.0...v0.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
What type of PR is this?
Other - Test cases
What does this PR do? Why is it needed?
Validates the basic functionality for the Go Packages Driver, and sets up a framework to add additional tests in the future.
Two major changes were needed to support all testing platforms:
\
, butsince
Bazel runs in Java it uses regular Windows paths (egC:\<some>\<path>
). So if we see a path like\C:\<some>\<path>
we have to remove the leading\
for go to be able tom resolve this path.This should help contributors validate that changes they make to this functionality and hopefully means less regressions overall.
Other notes for review
The goal is to test more scenarios, but wanted to send in the initial approach for review.