Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain param to affected actions #3760

Merged
merged 7 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/private/rules/test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ def _go_test_impl(ctx):
mnemonic = "GoTestGenTest",
executable = go.toolchain._builder,
arguments = [arguments],
toolchain = GO_TOOLCHAIN,
)

test_gc_linkopts = gc_linkopts(ctx)
Expand Down
1 change: 1 addition & 0 deletions proto/compiler.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def go_proto_compile(go, compiler, protos, imports, importpath):
progress_message = "Generating into %s" % go_srcs[0].dirname,
mnemonic = "GoProtocGen",
executable = compiler.internal.go_protoc,
toolchain = GO_TOOLCHAIN,
arguments = [args],
env = go.env,
# We may need the shell environment (potentially augmented with --action_env)
Expand Down