Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unused parameters when building the stdlib #3956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow unused parameters when building the stdlib #3956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go/platform/apple.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,7 @@ def apple_ensure_options(ctx, env, compiler_option_lists, linker_option_lists, t
min_version = _apple_version_min(ctx, platform, platform_type)
for compiler_options in compiler_option_lists:
compiler_options.append(min_version)
# Allow unused parameters since they are present in the stdlib src.
compiler_options.append("-Wno-unused-parameter")
for linker_options in linker_option_lists:
linker_options.append(min_version)
2 changes: 2 additions & 0 deletions go/private/context.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ _COMPILER_OPTIONS_DENYLIST = dict({
# fmax-errors limits that and causes build failures.
"-fmax-errors=": None,
"-Wall": None,
"-Wunused-parameter": None,
"-Wextra": None,

# Symbols are needed by Go, so keep them
"-g0": None,
Expand Down