Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jest example to jest@17 #2768

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

cuyl
Copy link
Contributor

@cuyl cuyl commented Jun 11, 2021

replace the patch with setting enableSymlinks to true. ref: #2338

Copy link
Collaborator

@mrmeku mrmeku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run buildifier to format your build files. That'll get CI to pass

replace the patch with setting enableSymlinks to true. ref: bazel-contrib#2338
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks!
We also have a copy of that jest-haste-map in the /patches folder, I guess we use it internally somewhere as well - if you have time for a second PR for that.

@alexeagle alexeagle merged commit a611b60 into bazel-contrib:stable Jun 14, 2021
@cuyl cuyl deleted the update-jest branch June 15, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants