Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement tars symlinks #559

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: implement tars symlinks #559

merged 1 commit into from
May 8, 2024

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented May 7, 2024

fixes #508, needs #558 first.

@thesayyn thesayyn changed the base branch from main to 2.x May 7, 2024 19:51
@thesayyn thesayyn requested a review from alexeagle May 7, 2024 19:54
@thesayyn
Copy link
Collaborator Author

thesayyn commented May 7, 2024

@gregmagolan is case you are interested, this is the one that will make RBE go fast.

@mortenmj
Copy link
Contributor

mortenmj commented May 7, 2024

Seeing a lot of very similar errors when testing this one. At the surface, it looks like this broke all of our images that we pass tars to (built with pkg_tar in our case). It looks like it's only a problem with remote execution. This is using Bazel 7.1.1.

Example output:

$ bazel build //services/tracing/lightstep-otel-collector:image_with_config_for_validation
INFO: Invocation ID: 66e79d22-3878-4a31-8524-b7c8ea9b4cca
INFO: Analyzed target //services/tracing/lightstep-otel-collector:image_with_config_for_validation (0 packages loaded, 0 targets configured).
ERROR: /workspaces/infrastructure/services/tracing/lightstep-otel-collector/BUILD.bazel:28:6: TreeArtifact services/tracing/lightstep-otel-collector/image_with_config_for_validation.image was not created
ERROR: /workspaces/infrastructure/services/tracing/lightstep-otel-collector/BUILD.bazel:28:6: OCI Image //services/tracing/lightstep-otel-collector:image_with_config_for_validation.image failed: not all outputs were created or valid
Target //services/tracing/lightstep-otel-collector:image_with_config_for_validation failed to build
INFO: Elapsed time: 0.782s, Critical Path: 0.03s
INFO: 2 processes: 1 remote cache hit, 1 internal.
ERROR: Build did NOT complete successfully

@thesayyn
Copy link
Collaborator Author

thesayyn commented May 8, 2024

That is interesting, do you have more information on this? eg which service are you using?

@thesayyn
Copy link
Collaborator Author

thesayyn commented May 8, 2024

This could be a Bazel bug!

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long journey to get here!

@thesayyn thesayyn merged commit 40884f6 into 2.x May 8, 2024
18 checks passed
@thesayyn thesayyn deleted the layer_symlink branch May 8, 2024 01:16
thesayyn added a commit that referenced this pull request May 8, 2024
thesayyn added a commit that referenced this pull request May 8, 2024
thesayyn added a commit that referenced this pull request May 8, 2024
thesayyn added a commit that referenced this pull request May 8, 2024
thesayyn added a commit that referenced this pull request May 8, 2024
thesayyn added a commit that referenced this pull request May 8, 2024
@mortenmj
Copy link
Contributor

mortenmj commented May 8, 2024

That is interesting, do you have more information on this? eg which service are you using?

We use Buildbarn. As far as I can tell, from looking at what got scheduled remotely, this never hit the build cluster at all.

Happy to help debug it.

thesayyn added a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Symlink tars instead of copying them.
3 participants