Use third_party Gazelle dependency instead of workspace Gazelle dependency #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
added a commit
to illicitonion/target-determinator
that referenced
this pull request
Jun 20, 2023
bazel-contrib#61 attempted to do this, but running gazelle undoes it - instead, tell gazelle to keep preserving this property.
illicitonion
added a commit
that referenced
this pull request
Jun 20, 2023
#61 attempted to do this, but running gazelle undoes it - instead, tell gazelle to keep preserving this property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60 did not succeed in fixing #59 because source depended on the WORKSPACE-declared gazelle version instead of the go.mod declared gazelle version. In addition to moving the dependency to match go.mod, add test coverage for the defect described in #59 to ensure resolution.