Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bazel-ios-fork to v2.10.2 #6

Draft
wants to merge 317 commits into
base: bazel-ios-fork
Choose a base branch
from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Oct 6, 2023

  1. Remove subscribeToBackplane, adjust failsafe op

    A shard server is impractical without operation subscription, partition
    subscription confirmation between servers and workers.
    The failsafe execution is configuration that is likely not desired on
    workers. This change removes the failsafe behavior from workers via
    backplane config, and relegates the setting of failsafe boolean to
    server config. If the option is restored for workers, it can be added to
    worker configs so that configs may continue to be shared between workers
    and servers and retain independent addressability.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9ff8e64 View commit details
    Browse the repository at this point in the history
  2. Removing AWS/GCP Metrics and Admin controls

    Internally driven metrics and scaling controls have low, if any, usage
    rates. Prometheus has largely succeeded independent publication of
    metrics, and externally driven scaling is the norm. These modules have
    been incomplete between cloud providers, and for the functional side of
    AWS, bind us to springboot. Removing them for the sake of reduced
    dependencies and complexity.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b21ab2e View commit details
    Browse the repository at this point in the history
  3. Remove unused setOnCancelHandler

    Remove this unused OperationQueue feature which provides no invocations
    on any use.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f97f048 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2c1544 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Configuration menu
    Copy the full SHA
    09015c9 View commit details
    Browse the repository at this point in the history
  2. Log write errors with worker address

    amishra-u authored and werkt committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1041b57 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Revert "Use integer ids for Sqlite bidirectional index"

    This reverts commit f651cdb.
    80degreeswest authored and werkt committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    30412ad View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    8379068 View commit details
    Browse the repository at this point in the history
  2. Cleanup matched logic in SWC listener

    Continue the loop while we have *not* matched successfully and avoid a
    confusing inversion in getMatched()
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fd20d13 View commit details
    Browse the repository at this point in the history
  3. Refactor SWC matcher and clarify Nullable

    Distinguish the valid/unique/propagating methods of entry listening.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    632fceb View commit details
    Browse the repository at this point in the history
  4. Interrupt matchStage to induce prepare shutdown

    The only signal to a waiting match that will halt its current listen
    loop for a valid unique operation is an interrupt.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7385c74 View commit details
    Browse the repository at this point in the history
  5. Specify example config with grpc target

    Distinguish target param with GRPC type storage from FILESYSTEM
    definition
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    79cf648 View commit details
    Browse the repository at this point in the history
  6. Remove SpringBoot usage

    Reinstate prior usage of LoggingMain for safe shutdown, with added
    release mechanism for interrupted processes. All invoked shutdowns are
    graceful, with vastly improved shutdown speed for empty workers waiting
    for pipeline stages.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d73628b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    6f88e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. refactor: code cleanup

    Tiny code cleanup
    jasonschroeder-sfdc authored and werkt committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    81122e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Log paths created on putDirectory

    Will include operation root and inform directory cache effectiveness.
    werkt committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ad44854 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Permit regex realInputDirectories

    Selecting realInputDirectories by regex permits flexible patterns that
    can yield drastic improvements in directory reuse for specialized
    deployments. runfiles in particular are hazardous expansions of
    nearly-execroot in the case of bazel.
    
    Care must be taken to match directories exclusively.
    The entire input tree is traversed for matches against expanded paths
    under the root, to allow for nested selection.
    Each match thus costs the number of input directories.
    Counterintuitively, OutputFiles are augmented to avoid the recursive
    check for OutputDirectories which only applies to actual reported
    results, resulting in a path match when creating the exec root.
    Regex style is java.util.Pattern, and must match the full input
    directory.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    b31ffed View commit details
    Browse the repository at this point in the history
  2. Log execPath rather than the cache dir path

    This will include the path to the missed directory and the operation
    which required it.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    1dec684 View commit details
    Browse the repository at this point in the history
  3. Shore up OutputDirectory for silence on duplicates

    Prevent adding duplicate realInputDirectories matches
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    6af857a View commit details
    Browse the repository at this point in the history
  4. Trigger realInputDirectories to have empty files

    Ensure that the last leg of the execution presents a directory, rather
    than the parent, per OutputDirectory's stamping.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    71a928c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8017bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5d88e54 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    21448c3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    461cc5a View commit details
    Browse the repository at this point in the history
  9. feat: support --redis_uri command line option

    Support a `--redis_uri` command line option for start-up.
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    b74531c View commit details
    Browse the repository at this point in the history
  10. docs(configuration): document the --redis_uri command line options

    also fixed some spelling typos.
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    d860b27 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    10bf139 View commit details
    Browse the repository at this point in the history
  12. chore: bump rules_jvm_external

    Bumping 4.2 -> 5.3
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9d4c86c View commit details
    Browse the repository at this point in the history
  13. chore: bump rules_cc

    Bump fro 0.0.6 -> 0.0.9
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    5bc4564 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    edf2211 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. build: override grpc dependencies with our dependencies

    Don't get transitive grpc dependencies, use the ones from our `maven_install(...)`
    jasonschroeder-sfdc authored and werkt committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    97e3b90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96f239d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af3f34e View commit details
    Browse the repository at this point in the history
  4. feat: add Proto reflection service to shard worker

    To aid connection troubleshooting
    jasonschroeder-sfdc authored and werkt committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    380f8a1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e7979d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1f9d01f View commit details
    Browse the repository at this point in the history
  7. Bug: Fix Blocked thread in WriteStreamObserver Caused by CASFile Write (

    buildfarm#1486)
    
    * Add unit test
    * Signal Write on complete
    amishra-u authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    578589f View commit details
    Browse the repository at this point in the history
  8. Pin the Java toolchain to remotejdk_17 (buildfarm#1509)

    Closes buildfarm#1508
    
    Cleanups:
    - remove the unused `ubuntu-bionic` base image
    - replace `ubuntu-jammy:jammy-java11-gcc` with `ubuntu-mantic:mantic-java17-gcc`
    - replace `amazoncorretto:19` with `ubuntu-mantic:mantic-java17-gcc`
    - swap inverted log file names in a file
    stefanobaghino authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    dfa5937 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f6459d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Support OutputPaths in OutputDirectory

    Specifying any number of OutputPaths will ignore OutputFiles (consistent
    with uploads). Where an OutputPath specifies an output directory, the
    action must be able to create the directory itself.
    werkt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    018e177 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Permit Absolute Symlink Targets with configuration

    Partial specification of the absolute symlink response per REAPI.
    Remaining work will be in output identification.
    werkt committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8b37013 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. chore: update bazel to 6.4.0 (buildfarm#1513)

    Trying to get more info on the Lombok stamping issue on Windows CI.
    See also bazelbuild/bazel#10363 and
    bazelbuild/bazel#18185
    jasonschroeder-sfdc authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    df9ce1d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    bd740c9 View commit details
    Browse the repository at this point in the history
  2. Create SymlinkNode outputs during upload (buildfarm#1515)

    Default disabled, available with createSymlinkOutputs option in Worker
    config.
    werkt authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2a61f77 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. feat: Implement CAS lease extension (buildfarm#1455)

    Problem
    
        Enabling the findMissingBlobsViaBackplane flag in BuildfarmServer eliminates the need for the BuildfarmWorker's fmb API call. This BuildfarmWorker:fmb call was also responsible for tracking CAS entry access. As result, our CAS cache eviction strategy shifted from LRU to FIFO.
        When the findMissingBlobsViaBackplane flag is enabled, the buildfarm relies on the backplane as the definitive source for CAS availability. Since we don't update CAS expiry on each access, the backplane will independently expire CAS entries based on the specified cas_expire duration, even if they are actively being read.
    
    Solution
    
    Updated bfServer:fmb call to perform non-blocking fmb calls to workers, allowing these workers to record access for the relevant CAS entries.
    
    Extended expiry duration for available CAS entries in the backplane on each fmb call.
    
    With these changes, we can utilize Bazel's experimental_remote_cache_lease_extension and experimental_remote_cache_ttl flags for incremental builds.
    
    Closes buildfarm#1428
    amishra-u authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    76c2657 View commit details
    Browse the repository at this point in the history
  2. Bump org.json:json from 20230227 to 20231013 in /admin/main (buildfar…

    …m#1516)
    
    Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
    - [Release notes](https://github.com/douglascrockford/JSON-java/releases)
    - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
    - [Commits](https://github.com/douglascrockford/JSON-java/commits)
    
    ---
    updated-dependencies:
    - dependency-name: org.json:json
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cfa2e18 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    ff00c8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    afb0603 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b5ec43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f9ef75a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    20512f6 View commit details
    Browse the repository at this point in the history
  6. Read through external with query THROUGH=true

    Specifying a correlated invocation id with a uri containing a
    THROUGH=true query param will cause the CFC to read a blob through an
    external input stream, populating locally along the way. This permits
    client-based replication of blobs, and can enable N+1 replication and
    traffic balancing for reads.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    654032e View commit details
    Browse the repository at this point in the history
  7. Add --port option to worker

    Option to run the worker with a cmdline specification for its gRPC
    server port.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b4359c5 View commit details
    Browse the repository at this point in the history
  8. Restore worker --root cmdline specification

    Root cmdline specification has been broken since the config change of
    v2.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5195809 View commit details
    Browse the repository at this point in the history
  9. Make bf-executor small blob names consistent

    Remove the size identification for small blobs when uploading with
    bf-executor.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    938c789 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configured output size operation failure

    Permit installations to control the failure process for operations which
    produce outputs larger than the maxEntrySizeBytes. A default value
    of false retains the existing behavior which appears transient and
    blacklists the executed action key. When enabled, the action will fail
    under an invalid violation that indicates user error.
    werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    87face1 View commit details
    Browse the repository at this point in the history
  2. Restore abbrev port as -p

    werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    58faec9 View commit details
    Browse the repository at this point in the history
  3. Update zstd-jni for latest version

    There's been a few releases of it by now and this pulls the latest. For
    buildfarm, notable changes included performance enhancments during
    decompression.
    
    See:
    https://github.com/facebook/zstd/releases/tag/v1.5.5
    jerrymarino authored and werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cf6fc58 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    6bc70e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b226725 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Detail storage requirements

    Update for further docs related to storage+type functionality
    Remove outdated Operation Queue worker definitions
    werkt authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    751ac90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bf3eae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6bddff View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Check for context cancelled before responding to error (buildfarm#1526)

    When a write fails because the write was already cancelled before due to something like deadline exceeded, we get an unknown error. The exception comes from here and when it gets to errorResponse(), it only checks if status code is cancelled. In this case the status code is unknown, so we need to check if context is cancelled to prevent responseObserver from being invoked
    
    The code change adds checking if context is cancelled and a unit test testing when the exception has context cancelled.
    justinwon777 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c490925 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a51c31 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    7ea1a9f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a4822c1 View commit details
    Browse the repository at this point in the history
  2. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f1ea9b5 View commit details
    Browse the repository at this point in the history
  3. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ccf763d View commit details
    Browse the repository at this point in the history
  4. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b7f5661 View commit details
    Browse the repository at this point in the history
  5. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    72b40ae View commit details
    Browse the repository at this point in the history
  6. Update ShardWorkerContext.java

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    14c759b View commit details
    Browse the repository at this point in the history
  7. Update ShardWorkerContext.java

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ca9bb92 View commit details
    Browse the repository at this point in the history
  8. [execution] allow tmpfs and cgroups enforcement

    tmpfs
    Previously we required bazel clients to opt-in with an exec_property. Now buildfarm has the ability to enforce tmpfs usage as part of deployment configuration.
    See: alwaysUseTmpFs: true
    
    cgroups
    cgroups was previously enabled via limitGlobalExecution. However, there was no way to opt-out of cgroups and opt-in to other restrictions. limitGlobalExecution is still required for accessing restrictions, but it will no longer guarantee cgroups is used. For that, deployments must set:
    See: alwaysUseCgroups: true
    
    Additional context
    We may also want to experiment with sandbox, but not cgroups in our deployment. There is currently no way to do this because enabling sandbox also requires enabling limitGlobalExecution, but doing so enables cgroups. By making these settings more granular we are able opt into and enforce particular execution wrappers.
    werkt authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    10e68c4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    35883a4 View commit details
    Browse the repository at this point in the history
  10. Update queues.md

    Refer to new camelized DMS fields.
    Expand predefined dynamic execution property name matches.
    werkt authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9d80f4e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Implement custom label header support for Grpc metrics interceptor (b…

    …uildfarm#1530)
    
    Add an option to provide a list of custom label headers to add to metrics.
    rastenis authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    aac33b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Specify direct guava dependency usage (buildfarm#1538)

    Testing with bazel HEAD using jdk21 compilation has revealed new
    direct dependencies on guava.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f9882f7 View commit details
    Browse the repository at this point in the history
  2. Update lombok dependency for jdk21 (buildfarm#1540)

    Annotations under lombok were fixed for jdk21 in 1.18.28, update to
    current.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    69e0248 View commit details
    Browse the repository at this point in the history
  3. Reorganize DequeueMatchEvaluator (buildfarm#1537)

    Remove acceptEverything DequeueMatchSetting
    Place worker name in workerProvisions
    Only enable allowUnmatched effects on key mismatch
    Only acquire resources after asserting compatibility
    Update documentation to match changes
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    339aa13 View commit details
    Browse the repository at this point in the history
  4. Upgrade com_google_protobuf for jvm compatibility (buildfarm#1539)

    Correct deprecated AccessController usage warning
    Requires a newer bazel than 6.4.0 for macos to choose unix toolchain with C++ std=c++14 specification for protobuf->absl dependency.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    025305a View commit details
    Browse the repository at this point in the history
  5. Create buildfarm-worker-base-build-and-deploy.yml (buildfarm#1534)

    Create a github workflow to build base buildfarm worker image.
    80degreeswest authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f720909 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b7daba3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dcff4f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    52318f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    e343393 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dae7f78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b01889d View commit details
    Browse the repository at this point in the history
  4. Check for "cores" exec property as min-cores match (buildfarm#1548)

    The execution platform property "cores" is detailed in documentation as
    specifying "min-cores" and "max-cores". Match this definition and
    prevent "cores" from being evaluated as a strict match with the worker
    provision properties (with likely rejection).
    werkt authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dcee798 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Consider output_* as relative to WD (buildfarm#1550)

    Per the REAPI spec:
    
    `The paths are relative to the working directory of the action
    execution.`
    
    Prefix the WorkingDirectory to paths used as OutputDirectory parameters,
    and verify that these are present in the layout of the directory for
    use.
    werkt authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    221eae9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Implement Persistent Workers as an execution path (buildfarm#1260)

    Followup to buildfarm#1195
    
    Add a new execution pathway in worker/Executor.java to use persistent workers via PersistentExecutor, like DockerExecutor.
    
    Mostly unchanged from the form we used to experiment back at Twitter, but now with tests.
    
    Co-authored-by: Shane Delmore [email protected]
    wiwa authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    91587e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Locate Output Paths relative to WorkingDirectory (buildfarm#1553)

    * Locate Output Paths relative to WorkingDirectory
    
    Required as a corollary to OutputDirectory changes to consider outputs
    as relative to working directory.
    
    * Windows builds emit relativize paths with native separators
    werkt authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a56b161 View commit details
    Browse the repository at this point in the history
  2. Remove incorrect external resolve of WD on upload (buildfarm#1554)

    Previous patch included a change in actionRoot parameter, expecting it
    to prefer the working directory rooted path to discover outputs. Might
    want to reapply this later, but for now leave the resolution in
    uploadOutputs.
    werkt authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    53e1fba View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Instance cleanups (buildfarm#1555)

    * Prevent multiple fetches of QueuedOperation
    
    Propagate the Tree in OperationContext for use during the persistent
    workers clause in Executor
    
    * Correct WSO and StubWriteOutputStream completion
    
    onCompleted should always be called on open requests when
    StubWriteOutputStreams are closed, even when completed early by the
    server.
    onCompleted must be delivered to responseObserver when onCompleted is
    invoked, lest a no-request write stream be left hanging to
    DEADLINE_EXCEEDED.
    
    * Explicit reset on WriteOffset 0 and blob write
    
    Avoid unnecessary queryWriteStatus requests when a WriteRequest
    appears with write offset 0 in WSO, and reset the stream initially for
    internal ServerInstance blob uploads.
    werkt authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    dd5c87b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d249393 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    a7ef693 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. add github action to package and publish the helm chart as a released…

    … artifact (buildfarm#1556)
    
    * bundle with helm
    publish release with gh cli
    
    * add a basic doc for the helm chart
    andrewrothstein authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a06b095 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    68182ec View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Write onNext requires onCompleted to follow (buildfarm#1565)

    For reasons passing understanding, a WriteResponse is not delivered to a
    client solely from onNext to be received by a client called via bsStub.
    onCompleted must follow the onNext for a timely delivery of the
    response, particularly when it occurs before an onCompleted from the
    client. This does not seem to affect the bazel client, which could
    indicate a difference in behavior between grpc versions, or simply that
    it manages to complete its upload completely ignorant of the early
    return status. More investigation is required.
    
    This will fix hanging builds which occur with exec-only workers failing
    to complete uploads to shard peers.
    werkt authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e26a000 View commit details
    Browse the repository at this point in the history
  2. chore: update maven dependencies (buildfarm#1434)

    * chore(deps): bump com.amazonaws:aws-java-sdk-*
    
    Update to 1.12.544
    
    * chore(deps): bump org.redisson:redisson
    
    Update to 3.23.4
    
    * chore(deps): bump org.threeten:threetenbp
    
    Update to 1.6.8
    
    * chore(deps): bump org.snakeyaml:snakeyaml
    
    Update to 2.2
    
    * chore(deps): bump com.github.docker-java:docker-java
    
    * chore(deps): bump com.github.jnr:*
    
    Bumping all packages in this groupId to the latest.
    
    * chore(deps): bump com.github.serceman:jnr-fuse
    
    * chore(deps): bump com.github.oshi:oshi-core
    
    * chore(deps): bump com.google.auth:*
    
    Oauth libraries to the latest.
    
    * chore(deps): bump com.google.code.findbugs:jsr305
    
    * chore(deps): bump com.google.code.gson:gson
    
    * chore(deps): bump com.google.j2objc:j2objc-annotations
    
    * chore(deps): bump com.google.jimfs:jimfs
    
    * chore(deps): bump org.slf4j.slf4j-simple
    
    * chore(deps): bump com.jayway.jsonpath:json-path
    
    * chore(deps): bump io.netty:*
    
    * chore(deps): bump io.prometheus:*
    
    * chore(deps): bump junit:junit
    
    * chore(deps): bump org.apache.commons:commons-compress
    
    * chore(deps): bump org.apache.commons:commons-pool2
    
    * chore(deps): bump org.apache.commons:commons-lang3
    
    * chore(deps): bump commons-io:commons-io
    
    * chore(deps): bump me.dinowernli:java-grpc-prometheus
    
    * chore(deps): bump org.checkerframework:checker-qual
    
    * chore(deps): bump com.google.truth:truth
    
    * chore(deps): bump org.openjdk.jmh:*
    jasonschroeder-sfdc authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    859abb6 View commit details
    Browse the repository at this point in the history
  3. build: support compiling protobuf on macOS (buildfarm#1563)

    MacOS needs extra args to convince it to support C++14.
    jasonschroeder-sfdc authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    27194c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1046e97 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. [tests] add unit test for local resources (buildfarm#1558)

    Add a unit test related to handling of local resources.
    luxe authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8d6e93f View commit details
    Browse the repository at this point in the history
  2. refactor: swap HealthStatusManager (buildfarm#1568)

    Swapping to the recommended class that isn't deprecated.
    
    Also, remove unnecessary String.format(...) with no format args.
    jasonschroeder-sfdc authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    fe2eba2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    284845a View commit details
    Browse the repository at this point in the history
  2. feat: Redis password from file (buildfarm#1569)

    * feat(config): read Redis password from Redis URI or redis password file
    
    * tests(common): add a test for build.buildfarm.common.config.Backplane
    
    * docs(configuration): document redisPasswordFile
    
    Documenting new configuration parameter and the precedence of each password option.
    jasonschroeder-sfdc authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8950953 View commit details
    Browse the repository at this point in the history
  3. docs: update AUTHORS and CONTRIBUTORS (buildfarm#1572)

    Adding myself and my copyright holder to `CONTRIBUTORS` and `AUTHORS`,
    respectively.
    jasonschroeder-sfdc authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    a4551f0 View commit details
    Browse the repository at this point in the history
  4. Identify Graceful Shutdown errors with severe (buildfarm#1574)

    Ensure that the log reflects these as errors, not just info
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    f9140c4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f76893e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1fa3c43 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cf3ac77 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ce31446 View commit details
    Browse the repository at this point in the history
  9. Determine PipelineStage exception severity (buildfarm#1579)

    Select pipeline stage terminations based on exception type.
    InterruptedExceptions are terminable.
    Errors are uncaught and will terminate the stage.
    All others are logged with the pipeline continuing.
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2a6f68c View commit details
    Browse the repository at this point in the history
  10. Authored sandbox asNobody behavior (buildfarm#1580)

    Describe a boolean authored to supply the as-nobody wrapper published
    with buildfarm deployments that should serve as a quick mechanism for
    any install to use non-buildfarm (typically root) uids for actions.
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    a0ec481 View commit details
    Browse the repository at this point in the history
  11. Provide Additional sandbox write paths in config (buildfarm#1581)

    Deployments may specify the paths that should be writable in sandbox
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9156123 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Declare stat block information for FuseCAS (buildfarm#1582)

    Useful so that a `du` and other block related tools work on the mounted
    directory.
    werkt authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b48032b View commit details
    Browse the repository at this point in the history
  2. Try a new version of jekyll (buildfarm#1583)

    Current version is failing with a gem bundler error
    werkt authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2097ef9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    d4de791 View commit details
    Browse the repository at this point in the history
  2. Remove rules k8s (buildfarm#1587)

    * build: remove rules_k8s
    
    The repo was archived May 12, 2023.
    
    * chore: remove unused k8s templates
    
    Please use the helm chart instead.
    
    * chore: Tiltfile updates to use helm chart instead
    jasonschroeder-sfdc authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f320a81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2870a3f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b52ac0 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. [CI] skip server/worker audit on mac (buildfarm#1592)

    * do not audit server/worker jars on mac
    
    Avoid python dependencies on mac unit test CI
    
    * Update presubmit.yml
    
    comment reference to underlying issue
    
    ---------
    
    Co-authored-by: George Gensure <[email protected]>
    luxe and werkt authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    78b001c View commit details
    Browse the repository at this point in the history
  2. Helm Chart: latest image tags not v-prefixed (buildfarm#1591)

    * latest images with versions not v-prefixed
    
    * stage 0.2.0 of the Helm chart
    andrewrothstein authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    b5425e0 View commit details
    Browse the repository at this point in the history
  3. Update helm values to use safe defaults (buildfarm#1597)

    Removed values which will likely cause problems for execution and CFC saturation from helm chart:
    inputFetchStage_width and execute_stage_width both can be discovered from available processors
    maxSizeBytes for filesystem cas is automatically 90% of underlying file storage, down from a value 10x the actual bytes on storage requested below.
    path, names, and configuration for root, filesystem, and publicName can all be defaulted/derived safely.
    werkt authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    41b4494 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Properly balance over nodes, not slot ranges (buildfarm#1598)

    Slot ranges must not associate multiple times on a single node for use
    with balanced queues designed to be load balanced.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    088b8e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b5db62 View commit details
    Browse the repository at this point in the history
  3. Use integer ids for Sqlite bidirectional index (buildfarm#1599)

    The cost in size for a single table bidirectional index is vast compared
    to the use of 3nf integer keys. Experimental estimates offer a decrease
    in file size of 90%.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    413021d View commit details
    Browse the repository at this point in the history
  4. Write cleanups (buildfarm#1600)

    * Guard against writeObserver null race
    
    * Avoid cancellation log for StubWriteOutputStream
    
    Cancels will happen for all server->worker uploads on context cancels
    initiated by clients, and are normal behaviors.
    
    * Guarantee null write response for onCompleted
    
    Avoid a complaint by gRPC that a client-streaming request was
    completed without a response
    
    * Reset remote CAS write on initial
    
    Prevents the StubWriteOutputStream from issuing an unnecessary initial
    queryWriteStatus.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    16b3aea View commit details
    Browse the repository at this point in the history
  5. fix: format without placeholders (buildfarm#1586)

    These instances of `format(...)` do not have placeholders and there's
    nothing to format.
    jasonschroeder-sfdc authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    51608f7 View commit details
    Browse the repository at this point in the history
  6. chore: Update proto file styling (buildfarm#1594)

    * chore: Update proto file styling
    
    * fix path
    
    * move protp styling to file
    
    * add new line at eof
    amishra-u authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    74b1f56 View commit details
    Browse the repository at this point in the history
  7. fix: Periodically Refresh Active Storage Workers With StartTime (buil…

    …dfarm#1549)
    
    * fix: Periodically Refresh Active Storage Workers With startTime
    amishra-u authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e51f1e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    c79b213 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Configuration menu
    Copy the full SHA
    044597e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Decode nodeId with jedis util SafeEncoder (buildfarm#1607)

    Node name strings provided via `cluster slots` will be byte arrays
    that require decoding. Use the inbuilt SafeEncoder from jedis which is
    used to decode all other strings.
    werkt authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    74316e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. build: start adopting bzlmod (buildfarm#1564)

    * build: start adopting bzlmod
    
    Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/)
    
    * build: swap io_bazel_rules_go for bzlmod
    
    * build: swap gazelle for bzlmod
    
    * tests: support bzlmod
    
    I don't know why. But it works.
    
    * build: leave breadcrumbs for bzlmod migration
    
    * build(chore): MODULE.bazel.lock
    
    * build: swap buildtools for buildifier_prebuilt
    
    There are conflicts with go tooling between buildtools and protobuf.
    jasonschroeder-sfdc authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b62a4ce View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. fix(coverage): coverage numbers are not accurate (buildfarm#1609)

    The awk was pulling out the denominator of the metric, not the percent.
    Adjust the field.
    
    Before:
    ```
    current line coverage:  1625%
    current function coverage:  340%
    ```
    
    after:
    ```
    current line coverage:  42%
    current function coverage:  51%
    ```
    jasonschroeder-sfdc authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    373cb21 View commit details
    Browse the repository at this point in the history
  2. Add helm lint CI job. Split tag/release for the Helm chart from the…

    … entire repo with tags: `helm/X.Y.Z-b1` (buildfarm#1602)
    
    * add helm chart linting stage, bundle chart on helm/* tags
    
    * fix triggers
    
    * try try again
    
    * always lint before bundling
    
    * extract the helm chart version from the git tag ref
    
    * fix name
    
    * tickle the beast
    
    * too much stack overflow
    
    * better names
    
    * that's output
    
    * gussy up readme
    
    * simplify
    
    * stage 0.2.2
    
    * put extraVolumeMounts under .Values.shardWorker
    
    * omit defaults
    
    * leave out emacs gitignore
    
    * wrong example
    andrewrothstein authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b40c14b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Publish storage worker and execute worker pool size in prometheus (bu…

    …ildfarm#1606)
    
    * Publish storage worker and execute worker pool size in prometheus
    
    * run formatter
    
    * add doc
    
    ---------
    
    Co-authored-by: Yuriy Belenitsky <[email protected]>
    amishra-u and 80degreeswest authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d155c0b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    646d956 View commit details
    Browse the repository at this point in the history
  2. Provide hashedName in BackplaneStatus Queue Name (buildfarm#1616)

    Avoid stripping the existingHash, used to calculate the slot with suffix
    modifiers for queue balancing. Client presentation may also move to
    presenting each balanced queue name, removing the coordinated
    calculation on the client.
    
    The name could only have been used by a client prior for name
    presentation or determination of queue names in redis from slot
    arrangement.
    werkt authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ea35e56 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. set expire and drop invocationId (buildfarm#1589)

    * set expire and drop invocationId
    
    * fix format
    
    * patch configuration doc
    
    * fix typo
    
    * re-run ci use luxe's patch
    
    * set expire when every active operation insert
    
    * fix return code
    
    * fix ci if statement
    
    ---------
    
    Co-authored-by: wangpengfei.pfwang <[email protected]>
    Co-authored-by: George Gensure <[email protected]>
    3 people authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fe2c51c View commit details
    Browse the repository at this point in the history
  2. Add OSSF scorecard (buildfarm#1618)

    * feat: add OSSF Scorecards workflow
    
    Adding OSSF Scorecards workflow as github action. It runs periodially.  Output goes into Code Scanning alerts of GitHub.
    
    * docs(README): add some badges
    
    - OSSF Scorecard
    - License (from GitHub)
    - latest Release (from GitHub)
    jasonschroeder-sfdc authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b7980a0 View commit details
    Browse the repository at this point in the history
  3. chore: remove rules_oss_audit (buildfarm#1617)

    Remove rules_oss_audit and accompanying documentation
    jasonschroeder-sfdc authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8a7873b View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    bb60196 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    8a3abb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. fix template bugs with with (buildfarm#1631)

    * fix template bugs with with
    
    * stage chart v0.2.3
    andrewrothstein authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    60b3890 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1eb0528 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Configuration menu
    Copy the full SHA
    cab70f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. migrate dependency to Bitnami Redis helm chart (buildfarm#1637)

    * rework for bitnami redis helm chart
    
    * still doesn't work tho less specified
    
    * disable redis pwd -- not for production use
    
    * chart/bitnami-redis:18.14.2
    
    * and later
    
    * stage chart v0.3.0
    andrewrothstein authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    14810a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Dequeue flags expire after timeout effect (buildfarm#1642)

    The flag key which contains a timeout for an operation that has been
    observed in a Queue's Dequeue (atomic safeguard list, either queue or
    dequeue) must not expire before the time it will be expired, and
    reasonably not before the time it takes a failsafe period to identify
    the timeout has elapsed. This was broken in buildfarm#713, where the original
    expiry was 2x the configured timeout, and reduced to just the timeout in
    seconds. We now set the expiry to 1 hour or 10x the timeout, to make
    unlikely an expiry clearing the flag in a working system. Commented
    loudly to avoid removing the same padding again.
    werkt authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7ec7fdb View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Update .bazelversion to use bazel 7.0.2 (buildfarm#1641)

    * Update .bazelversion to use bazel 7.0.0
    
    Bump bazel to v7.0.0
    
    * Update .bazelversion
    80degreeswest authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b38568b View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Disable rules_docker transitions (buildfarm#1648)

    This PR fixes the issues introduced by setting default bazel version to 7, which is now breaking CI.
    
    Example errors:
    
    in constraint_values attribute of platform rule @@io_bazel_rules_docker//platforms:image_transition: '@@io_bazel_rules_docker//platforms:image_transition_cpu' does not have mandatory providers: 'ConstraintValueInfo'
    
    Analysis of target '@@io_bazel_rules_docker//platforms:image_transition' failed
    ERROR: /home/yuriyb/bazel-buildfarm/BUILD:119:11: Target @@io_bazel_rules_docker//platforms:image_transition was referenced as a platform, but does not provide PlatformInfo
    80degreeswest authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4318801 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. style: buildifier (buildfarm#1653)

    >buildifier -mode fix -lint fix -r .
    jasonschroeder-sfdc authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    535515b View commit details
    Browse the repository at this point in the history
  2. chore: update CODEOWNERS (buildfarm#1654)

    Removing a stale codeowner that's not part of the repo anymore, per
    GitHub warning.
    jasonschroeder-sfdc authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    6994b3c View commit details
    Browse the repository at this point in the history
  3. build: pin python-dateutil (buildfarm#1657)

    v2.9.0 seems to not be so compatible with python2
    jasonschroeder-sfdc authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ea78d25 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    9bc6b02 View commit details
    Browse the repository at this point in the history
  2. build(protobuf): switch to protobuf from BCR (buildfarm#1656)

    Swap to using the protobuf dependency directly from Bazel Central
    Registry (BCR) at http://registry.bazel.build
    
    This is a downgrade (25.0->23.1), but 23.1 is the latest in the BCR today.
    jasonschroeder-sfdc authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    55ac48c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f2166af View commit details
    Browse the repository at this point in the history
  4. docs(metrics): Update prometheus metrics (buildfarm#1650)

    Some of these don't exist in the code anymore.
    Also, labeled some metric types.
    jasonschroeder-sfdc authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    c5335c0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80b5bde View commit details
    Browse the repository at this point in the history
  6. build(bzlmod): turn off lockfile completely (buildfarm#1651)

    There are platform-specific parts that need to be kept up-to-date.
    A macOS developer might not be able to update the linux/amd64 parts of
    the manifest.
    jasonschroeder-sfdc authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    cf5f08f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    1fa529b View commit details
    Browse the repository at this point in the history
  2. build: remove docker download install pkgs actions (buildfarm#1663)

    * build: use pre-built ubuntu-mantic image
    
    * chore: prune unused images
    jasonschroeder-sfdc authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    04ff216 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. fix(common): do not log redis password on start-up

    Do not log passwords on start-up.
    jasonschroeder-sfdc authored and werkt committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bc4156d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    2490ada View commit details
    Browse the repository at this point in the history
  2. chores: bump google-java-format to 1.20.0 (buildfarm#1649)

    * chores: bump google-java-format to 1.20.0
    
    * style: apply google-java-format 1.20.0
    
    * style: drop extra semicolons
    
    * docs: update documentation URL
    
    Updating the documentation link.
    jasonschroeder-sfdc authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7376458 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Include resources description

    werkt authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    898033a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    581d30f View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. build(bzlmod): Switch to rules_oci (buildfarm#1667)

    * build: swap rules_docker for rules_oci
    
    * build: remove images.bzl
    
    * build: convert java_library to pkg_tar for various container things
    
    * build: add container tests
    
    Add tests from container_structure_test
    
    * build: Sort out the selector() for env vars
    
    * chore: typos
    
    * fix(helm): update helm chart
    
    Updating helm chart's image, and move CONFIG_PATH from an arg to an env var.
    jasonschroeder-sfdc authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3b1b99a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. build: bump maven version to latest (buildfarm#1670)

    Bumping the maven version to the latest.
    jasonschroeder-sfdc authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5968965 View commit details
    Browse the repository at this point in the history
  2. ci: Fix rules_oci docker publish (buildfarm#1671)

    * ci: fix docker image push
    
    * docs(README): add Docker download badge to README
    jasonschroeder-sfdc authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9c4014f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Fix link to IJ screenshot

    stefanobaghino authored and werkt committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f0d43d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0918eef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6dcf737 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    14ba613 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. build: pin ubuntu-mantic image

    jasonschroeder-sfdc authored and werkt committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    236fb8c View commit details
    Browse the repository at this point in the history
  2. add ingress for the server

    andrewrothstein authored and werkt committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    04478cc View commit details
    Browse the repository at this point in the history
  3. fix service.port reference

    andrewrothstein authored and werkt committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    f653091 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Switch to jedis-5

    werkt committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    abd0881 View commit details
    Browse the repository at this point in the history
  2. Calculate slot lookup table once per app instance

    The slot key index is invariant for all usage, calculate it once and
    avoid a costly lookup for successive calls to RedisSlotToHash.correlate.
    Evidenced in slow unit tests, but may improve production runtime as
    well. Provide an initial capacity to the slots ArrayList to boot.
    werkt committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    76a1e00 View commit details
    Browse the repository at this point in the history
  3. Switch jedis dequeue over to milli granularity

    Speeds up tests dramatically.
    werkt committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    96a0c87 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e3db2e View commit details
    Browse the repository at this point in the history
  5. Merge pull request buildfarm#1679 from jasonschroeder-sfdc/bump_ci_bu…

    …ildifier
    
    ci: bump buildifier to 6.4.0
    Wyverald authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    719a022 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2db583a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    97d0093 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    788f7ea View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. build(bzlmod): update rules_pkg (buildfarm#1646)

    * build(rules_pkg): switch to bzlmod dependency
    
    * build: add more toolchains for rpms
    
    * build: satisfy buildkite
    
    * refactor: swap genrule for rules_pkg
    
    * tests: container tests
    
    - update single-quotes to double quotes for consistency
    - add file permissions for skip_sleep_preload.so
    jasonschroeder-sfdc authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1501dd4 View commit details
    Browse the repository at this point in the history
  2. publish Helm chart as OCI artifact to ghcr.io (buildfarm#1683)

    in lieu of publishing a tgz as a GitHub release artifact, this change publishes (on tag helm/${semver}) the Helm chart bundled as an OCI artifact to the GitHub container registry, i.e. ghcr.io. I also updated the installation instructions which are now less gory. This change requires granting public read access to the corresponding buildfarm "package" within the bazel-buildfarm project. It defaults to private.
    andrewrothstein authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e1ad3ad View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Configuration menu
    Copy the full SHA
    66ce90d View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. fix: remove redis hashtags from prometheus metrics (buildfarm#1693)

    Strip the redis hashtags from the `queue_size` metric
    
    Fixes: buildfarm#1687
    jasonschroeder-sfdc authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    2a8afb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    c61e824 View commit details
    Browse the repository at this point in the history
  2. Support for BLAKE3 digest function (buildfarm#1697)

    Incorporate support for BLAKE3 digest exclusively on a server instance
    Compressor + Digest + DigestFunction.Value coupling should mean that
    BlobInformation could cut down on params.
    
    Still much to do to support the new DigestFunction.Value fields in many
    messages, and no migration support for this (or any other) function.
    First foray into JniLoader native behavior, adapted from bazel
    implementation of blake3 support.
    werkt authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    89a97d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4cbcd4a View commit details
    Browse the repository at this point in the history
  4. chore: remove bazel binary

    This is a platform-specific (linux x68_64) binary of unknown origin.
    
    To build buildfarm, use Bazelisk. See README for more info.
    jasonschroeder-sfdc authored and werkt committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0bc8a59 View commit details
    Browse the repository at this point in the history
  5. fix(ServerInstance): fix severe log message

    Looks like copy/pasted log message.
    jasonschroeder-sfdc authored and werkt committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b7bcda3 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    684d79a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Fix jedismock tests on mac

    werkt committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1366869 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    3d2383f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. fix(metrics): convert Gauges to Counters

    These are only being `inc()` (incremented) and will be better
    represented as Counters rather than Gauges.
    jasonschroeder-sfdc authored and werkt committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    12faac7 View commit details
    Browse the repository at this point in the history
  2. docs(metrics.md): update metric types

    Updating Gauge->Counter for:
    - operations_stage_load
    - operation_status
    - operation_exit_code
    - operation_worker
    jasonschroeder-sfdc authored and werkt committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d0bbc5f View commit details
    Browse the repository at this point in the history
  3. fix(RedisShardBackplane): fix backplaneStatus

    - re-factor to use chained builder pattern
    - fix the calls to `client.call(jedis -> ...)`
    jasonschroeder-sfdc authored and werkt committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d270aa9 View commit details
    Browse the repository at this point in the history
  4. refactor for clarity

    Refactor for readability
    jasonschroeder-sfdc authored and werkt committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5c19f87 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    d989027 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    296427d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a4046f View commit details
    Browse the repository at this point in the history
  4. build: add rules_java

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5c618f8 View commit details
    Browse the repository at this point in the history
  5. build: move maven things to MODULE.bazel

    Also, update maven mirrors
    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    36614cd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b1e9c36 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4bb7d77 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ce0084b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6f8631c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3033a95 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c2a1119 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    cf0af56 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f340082 View commit details
    Browse the repository at this point in the history
  14. temp: remove llvm toolchain

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f7f9eda View commit details
    Browse the repository at this point in the history
  15. build: bazel_remote_apis bzlmod

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8e65eea View commit details
    Browse the repository at this point in the history
  16. build: grpc is working now

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2bacdd4 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    69b2190 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f85f05e View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    62b5689 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    edc8809 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4c7ed16 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    23396ec View commit details
    Browse the repository at this point in the history
  23. build(bzlmod): add bazel_skylib

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0b2ce12 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    2f9c85e View commit details
    Browse the repository at this point in the history
  25. chore: remove defs.bzl

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    29e8114 View commit details
    Browse the repository at this point in the history
  26. chore: remove unused patches

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4b9b2fb View commit details
    Browse the repository at this point in the history
  27. chore(bzlmod): bump rules_go

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3814203 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    e7bf216 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    013fd4d View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    745d7d2 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    cd71055 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    65f8923 View commit details
    Browse the repository at this point in the history
  33. build: remove io_grpc_grpc_java

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2581a29 View commit details
    Browse the repository at this point in the history
  34. build: googleapis

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5d56d30 View commit details
    Browse the repository at this point in the history
  35. build: add com_github_grpc_grpc

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    880771a View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    9169a4e View commit details
    Browse the repository at this point in the history
  37. build: BUILD

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    813ac03 View commit details
    Browse the repository at this point in the history
  38. chore: pin maven deps

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    808a01c View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    2b3f0b2 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    91a7a7e View commit details
    Browse the repository at this point in the history
  41. fixup! build: BUILD

    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    910714b View commit details
    Browse the repository at this point in the history
  42. build: don't make buildifier a dev dependency

    Since we declare a buildifier target in //BUILD, we can't make this a
    dev dependency.
    jasonschroeder-sfdc authored and werkt committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    27e8d2e View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    481d627 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Prevent write completion starvation for duplicates

    When a duplicate output stream is detected, we must signal the
    writeWinner (because the write exists) and onInsert (because it was
    inserted) for an output stream creation. If we're racing, we should be
    eventually convergent, but this absolutely fixes a hang which occurs on
    this sentinel stream's return into getOutput, where the future might
    never be triggered otherwise.
    werkt authored and 80degreeswest committed May 31, 2024
    Configuration menu
    Copy the full SHA
    bb1f766 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Reduce DUPLICATE_OUTPUT_STREAM future to write

    Move future completion into the only scope it was actually missing from
    - getOutput for Write, rather than inducing all `put` calls into posts
    to backplane via onPut with duplicates.
    werkt authored and 80degreeswest committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    ece844a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Revert "Temporary fix to use the official Blake3 support"

    This reverts commit 99eca33.
    chenj-hub committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8bbaada View commit details
    Browse the repository at this point in the history
  2. Merge commit 'ece844a103eb0561a2bd1bf91129c12915a28ea8' into jackies/…

    …upgrade-bazel-buildfarm-to-v2.10.2
    chenj-hub committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    26cb1df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64b71b2 View commit details
    Browse the repository at this point in the history