-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload binary release artifact per commit #262
Merged
Merged
Commits on Sep 29, 2020
-
Upload binary release artfact on all builds
This PR adds the ability to upload release artifact via XCHammer's github CI. On each build, we upload the binary release artifact `xchammer.zip` which can be pulled into a bazel `WORKSPACE` with `http_archive` and then used as expected. At first, I'd considered creating a release on each commit but that has a few complexities in github actions e.g. can't create a release w/o a tag, and would end up annoying watchers of the repository with a release email on each commit landed. Perhaps there could be a better way to navigate to these artifact URLs in the github UI longer term.
Configuration menu - View commit details
-
Copy full SHA for 29af49b - Browse repository at this point
Copy the full SHA 29af49bView commit details
Commits on Sep 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46c4920 - Browse repository at this point
Copy the full SHA 46c4920View commit details
Commits on Oct 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4dc05e6 - Browse repository at this point
Copy the full SHA 4dc05e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c269d5 - Browse repository at this point
Copy the full SHA 6c269d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bc035b - Browse repository at this point
Copy the full SHA 1bc035bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0fc3cb - Browse repository at this point
Copy the full SHA d0fc3cbView commit details -
Upload a release artifact when pushing a tag v*
The github actions API doesn't play well with per commit artifacts. For now we create a release when pushing a tag. Consuming the per commit artifacts w/o the github actions API is blocked by this: actions/upload-artifact#50
Configuration menu - View commit details
-
Copy full SHA for 5185482 - Browse repository at this point
Copy the full SHA 5185482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3186bab - Browse repository at this point
Copy the full SHA 3186babView commit details -
Configuration menu - View commit details
-
Copy full SHA for 004ea8e - Browse repository at this point
Copy the full SHA 004ea8eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.