Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty glob in boost.thread #3142

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Nov 8, 2024

Needs skip-url-check

@bazel-io
Copy link
Member

bazel-io commented Nov 8, 2024

Hello @wep21, @Vertexwahn, modules you maintain (boost.thread) have been updated in this PR. Please review the changes.

@Vertexwahn
Copy link
Contributor

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 8, 2024
@Vertexwahn
Copy link
Contributor

@hofbi See my last comment - you can get the skip-url-stability-check label by posting this comment

Vertexwahn
Vertexwahn previously approved these changes Nov 8, 2024
bazel-io
bazel-io previously approved these changes Nov 8, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy enabled auto-merge (squash) November 8, 2024 13:37
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 8, 2024
auto-merge was automatically disabled November 8, 2024 19:19

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from Vertexwahn and themself November 8, 2024 19:19

Require module maintainers' approval for newly pushed changes.

@Vertexwahn
Copy link
Contributor

Seems that Bazel 8 requires rules_cc...

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy merged commit 6d2583f into bazelbuild:main Nov 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants