resolve: detect when a rule imports itself #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add selfImportError, which is now returned by RuleIndex.findRuleByImport and related methods when a rule imports itself (which is common with protos). Resolver methods treat this error the same as standardImportError: no dependency is emitted. Fixes bazelbuild#45
ianthehat
approved these changes
Dec 26, 2017
ashi009
reviewed
Dec 27, 2017
| break | ||
| } | ||
| parts := strings.Split(m.label.Pkg, "/") | ||
| for i, part := range parts { |
There was a problem hiding this comment.
How about
if idx := strings.Index(m.label.Pkg, "/vendor/"); idx > 0 {
isVendored = true
vendorRoot = m.label.Pkg[:idx]
}
There was a problem hiding this comment.
Please ignore. This is not covering some corner cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selfImportError, which is now returned by
RuleIndex.findRuleByImport and related methods when a rule imports
itself (which is common with protos).
Resolver methods treat this error the same as standardImportError: no
dependency is emitted.
Fixes #45