Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused argument in print statement #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prestonvanloon
Copy link

Resolves #836

This argument was not used. I'm not sure if it was useful so this PR proposes to remove it entirely.

I'd be happy to add to the print statement in this PR if anyone feels differently.

@@ -202,7 +202,6 @@ def validateUseOfCheckedInConfigs(
"and/or 'create_cc_configs = %s' passed as attrs") %
(
name,
bazel_version,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would instead modify this to:

print(("%s not using checked in configs; '%s' was picked/selected as a candidate matching config for Bazel %s from whose list of compatible configs are %s" +
               "but it does not match " +
               "the 'env = %s', 'config_repos = %s', " +
               "and/or 'create_cc_configs = %s' passed as attrs") %
              (
                  name,
                  config,
                  bazel_version,
                  str(bazel_compat_configs),
                  env,
                  config_repos,
                  create_cc_configs,
              ))

or something similar

smukherj1 pushed a commit that referenced this pull request Aug 14, 2020
Taken suggestion from: #837 (comment)

Signed-off-by: William A Rowe Jr <[email protected]>
Co-authored-by: Sunjay Bhatia <[email protected]>

Co-authored-by: William A Rowe Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel_version is not used in this print statement
3 participants