Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding os_family in rbe_autoconfig #935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevingessner
Copy link

(Rebased and making a PR on behalf of @ulfjack, who wrote this patch)

Provides a workaround for #895.

Use like this:
rbe_autoconfig(
name = "engflow_remote_config",
os_family = "Linux",
java_home = "/usr/lib/jvm/11.29.3-ca-jdk11.0.2/reduced",
use_checked_in_confs = "Force",
)

Provides a workaround for bazelbuild#895.

Use like this:
rbe_autoconfig(
    name = "engflow_remote_config",
    os_family = "Linux",
    java_home = "/usr/lib/jvm/11.29.3-ca-jdk11.0.2/reduced",
    use_checked_in_confs = "Force",
)
@google-cla
Copy link

google-cla bot commented Jan 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 29, 2021
@smukherj1
Copy link
Collaborator

@kevingessner FYI we're exploring the possibility of exploring rbe_autoconfig for config generation with a standalone Go CLI (see PR #936 for a proof of concept). We expect this CLI will make it easier to generate configs (mostly for our internal config generation automation as well as for new users setting up config generation for themselves).

The CLI currently supports Linux & Windows to start out but I imagine Mac OS support should be trivial to add. We're still experimenting with this tool and will share more details in the coming weeks but initial thoughts are welcome.

Right now the Go code also potentially be used as a library and we would be open to suggestions on what components of the tool should be exported to make it more pluggable. This will be especially important for potential Windows/OSX specific support that we might not initially be able to set up testing for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants