Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
fmeum committed Aug 23, 2024
1 parent 68b9dad commit 2c82260
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ default boolean mayInsensitivelyPropagateInputs() {
}

/**
* Returns true if the action may modify its outputs after executing spawns.
* Returns true if the action may modify spawn outputs after the spawn has executed.
*
* <p>If this returns true, any kind of spawn output caching or reuse needs to happen
* synchronously directly after the spawn execution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,6 @@ public CacheHandle lookup(Spawn spawn, SpawnExecutionContext context)
previousExecution =
previousOrThisExecution == thisExecution ? null : previousOrThisExecution;
}
// Metadata will be available in context.current() until we detach.
// This is done via a thread-local variable.
try {
RemoteActionResult result;
try (SilentCloseable c =
Expand Down Expand Up @@ -269,7 +267,9 @@ public void store(SpawnResult result) throws ExecException, InterruptedException
// existing executions finish the reuse.
// Note that while this call itself isn't interruptible, all operations it awaits are
// interruptible.
thisExecutionFinal.awaitAllOutputReuse();
try (SilentCloseable c = prof.profile(REMOTE_DOWNLOAD, "await output reuse")) {
thisExecutionFinal.awaitAllOutputReuse();
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ public NestedSet<Artifact> getPossibleInputsForTesting() {
public boolean mayModifySpawnOutputsAfterExecution() {
// Causes of spawn output modification after execution:
// - Fallback to the full classpath with --experimental_java_classpath=bazel.
// - In-place rewriting of .jdeps files when with --experimental_output_paths=strip.
// - In-place rewriting of .jdeps files with --experimental_output_paths=strip.
return true;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ protected void afterExecute(
@Override
public boolean mayModifySpawnOutputsAfterExecution() {
// Causes of spawn output modification after execution:
// - In-place rewriting of .jdeps files when with --experimental_output_paths=strip.
// - In-place rewriting of .jdeps files with --experimental_output_paths=strip.
// TODO: Use separate files as action and spawn output to avoid in-place modification.
return true;
}
Expand Down

0 comments on commit 2c82260

Please sign in to comment.