-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android tool causing Desugar action to fail when building Android tools from source #11618
Comments
@jin fyi |
Getting a different issue after this fix, see:
|
I have the same issue when desugaring okhttp with Bazel 3.3 - no problem with Bazel 3.2. |
I'm gonna try that - I never built Bazel myself so that might take a while. |
Thanks, you can follow the additional instructions in #11618 (comment) of this issue to build the desugar tool because it's unbundled from Bazel. |
I tried both with and without the repo override, and in both cases I got the same error that I have with Bazel 3.3.0 - the one just above. |
Gotcha, so there are really two bugs here. FYI @dx404 |
I see the issue. None of our tests cover the primitive type desugaring feature required by that missing desugar resource. Will submit a fix. |
Tested out the latest patch but I now get yet another new error:
I'm not really sure who triggers DexMapper or how your change might of broke it. When compiling the DexMapper target directly with "_deploy.jar" I do see the class in the expected location. |
@jin I see that this is now closed, does your fix account for the latest |
No, it doesn't. Can you file another bug for that with repro steps? The linked commit fixes the worker strategy desugar issue. |
Were you able to build an Android App after your fix? The repro steps was to use your fix and attempt to build an app which failed with this DexMapper issue for me |
Yes, I was able to build the Android apps in rules_jvm_external, and the integration tests on CI are passing. I haven't seen that error while trying to fix the Desugar issue. |
Bazel 3.3.1 RC1 is now available: https://releases.bazel.build/3.3.1/rc1/index.html Please test this against the errors in this issue. |
@katre happy to test it out but I'm not really sure how to do it with the link you provided. I need to be able to rebase off of Bazel 3.3.1 RC1 branch/tag as we use a custom fork of Bazel. |
Every release candidate is a branch on Github, see here: https://github.com/bazelbuild/bazel/tree/release-3.3.1rc1 |
Great I can work with that, thanks! |
Right, that's only for finalized releases, this is a candidate (which is why it's a branch, not a tag). It'll end up there once it's fully released. |
Still getting the |
The DexMapper issue is not related to this issue. This issue has been fixed in 3.3.1. |
@nkoroste if you have a way to repro the DexMapper issue, please create a new issue for us to track it. |
@jin I finally figured out what the issue was - It was related to sandboxing and the
which resulted in this:
When I manually ran the I can file a seperate bug for this, unless this a user error and there is a more official way to use locally built android_tools? |
Yes, please file a separate bug as it looks like it's from a different failure mode. |
done - #11810 |
Description of the problem / feature request:
When building Android Tools from the tip of Bazel 3.3.0 branch an error is thrown in Desugar worker log saying:
Error parsing command line: Unrecognized option: --persistent_worker
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Build Android tools from source and try to build Android binary target using them
bazel build //src:bazel-dev //tools/android/runtime_deps:android_tools
mkdir -p /tmp/bazel_android_tools
tar -xzvf bazel-bin/tools/android/runtime_deps/android_tools.tar.gz -C /tmp/bazel_android_tools
./bazelw build --override_repository=android_tools=/tmp/bazel_android_tools //apps/myApp:app
Also tried doing the same steps but with at SHA f3d1683 from here:
f3d1683#diff-6f653881793ed1c14a8c9d92a49705b1
Also with no luck, I get the same error.
What operating system are you running Bazel on?
Linux/Mac
What's the output of
bazel info release
?3.3.0
Have you found anything relevant by searching the web?
Any other information, logs, or outputs that you want to share?
The text was updated successfully, but these errors were encountered: